Skip to content

London | 26-ITP-JAN | Shuheda Begum | Sprint 3 | Quote Generator#1011

Open
codebyshay wants to merge 6 commits intoCodeYourFuture:mainfrom
codebyshay:Quote-generator
Open

London | 26-ITP-JAN | Shuheda Begum | Sprint 3 | Quote Generator#1011
codebyshay wants to merge 6 commits intoCodeYourFuture:mainfrom
codebyshay:Quote-generator

Conversation

@codebyshay
Copy link
Copy Markdown

@codebyshay codebyshay commented Mar 14, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created quote generator.

Questions

No questions

@github-actions

This comment has been minimized.

Sign in to view
5 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@codebyshay codebyshay mentioned this pull request Mar 21, 2026
Open
@codebyshay codebyshay added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 28, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
Luro91
Luro91 reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit

Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment on lines +1 to +3
//CREATE PR


Copy link
Copy Markdown

@Luro91 Luro91 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this comment for?

Copy link
Copy Markdown
Author

@codebyshay codebyshay Apr 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. Noted.

The //CREATE PR was something I typed to make a tiny change so I could create a PR and test my commit was being translated back to my github. I'm a newbie to coding and I've had issues with this in the past. I should have deleted it.

Copy link
Copy Markdown

@Luro91 Luro91 Apr 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. It's good practice to remove code comments and debug statements that were used during the development. I usually do a self review of my own pull request to spot such leftover code.

Please remove it as it's not needed anymore

Copy link
Copy Markdown
Author

@codebyshay codebyshay Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment thread Sprint-3/quote-generator/quotes.js Outdated
if (autoplayToggle.checked) {
// Switch is ON
autoplayStatus.innerText = "auto-play: ON";
timerId = setInterval(updateQuote, 5000);
Copy link
Copy Markdown

@Luro91 Luro91 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation of the stretch task.
The tasks says the time until the quote switches should be 60s

Copy link
Copy Markdown
Author

@codebyshay codebyshay Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thank you.

Code updated :)

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 6, 2026
@codebyshay codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 10, 2026
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 11, 2026
@codebyshay codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 11, 2026
@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 12, 2026
Luro91
Luro91 reviewed Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Now the code looks clean

@codebyshay
Copy link
Copy Markdown
Author

codebyshay commented Apr 12, 2026

Well done. Now the code looks clean

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Luro91 Luro91 Luro91 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebyshay @Luro91