Sheffield | 26-ITP-Jan | Karim M'hamdi | Sprint 1 | Module-Data-Groups

Sprint-1/fix/median.js

@@ -6,9 +6,24 @@
 // or 'list' has mixed values (the function is expected to sort only numbers).
 
 function calculateMedian(list) {
-  const middleIndex = Math.floor(list.length / 2);
-  const median = list.splice(middleIndex, 1)[0];
-  return median;
+  if (!Array.isArray(list)) {
+    return null;
+  }
+  const numbersOnly = list.filter(item => typeof item === 'number');
+  const sorted = [...numbersOnly].sort((a, b) => a - b);
+
+  if (sorted.length === 0) {
+    return null;
+  } else if (sorted.length % 2 === 0) {
+    const mid1 = sorted.length / 2 - 1;
+    const mid2 = sorted.length / 2;
+    const median = (sorted[mid1] + sorted[mid2]) / 2;
+    return median;
+  } else {
+    const middleIndex = Math.floor(sorted.length / 2);
+    const median = sorted[middleIndex];
+    return median;
+  }
 }
 
 module.exports = calculateMedian;

Sprint-1/fix/median.test.js

@@ -22,7 +22,7 @@ describe("calculateMedian", () => {
     { input: [4, 2, 1, 3], expected: 2.5 },
     { input: [6, 1, 5, 3, 2, 4], expected: 3.5 },
     { input: [110, 20, 0], expected: 20 },
-    { input: [6, -2, 2, 12, 14], expected: 6 },
+    { input: [6, -2, 2, 12, 14], expected: 6},
   ].forEach(({ input, expected }) =>
     it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
   );

Sprint-1/implement/dedupe.js

@@ -1 +1,13 @@
-function dedupe() {}
+function dedupe(array) {
+  let seen = new Set();
+  let result = [];
+    for (let item of array) {
+        if (!seen.has(item)) {
+            seen.add(item);
+            result.push(item);
+        }
+    }
+    return result;
+}
+
+module.exports = dedupe;

Sprint-1/implement/max.js

@@ -1,4 +1,12 @@
-function findMax(elements) {
+function findMax(elements){
+    let max = -Infinity;
+   for (let i = 0; i < elements.length; i++) {
+     if (typeof elements[i] === "number")
+       if (elements[i] > max) {
+         max = elements[i];
+       }
+   }
+    return max;
 }
 
 module.exports = findMax;

Sprint-1/implement/sum.js

@@ -1,4 +1,14 @@
-function sum(elements) {
+function sum(elements)
+{    let sum = 0;
+    for (let i = 0; i < elements.length; i++) {
+        if (typeof elements[i] === "number"){
+            sum += elements[i];
+        }
+    }
+
+    return sum;
 }
 
+
+
 module.exports = sum;

Sprint-1/refactor/includes.js

@@ -1,12 +1,11 @@
 // Refactor the implementation of includes to use a for...of loop
 
 function includes(list, target) {
-  for (let index = 0; index < list.length; index++) {
-    const element = list[index];
-    if (element === target) {
-      return true;
+    for (const element of list) {
+        if (element === target) {
+            return true;
+        }
     }
-  }
   return false;
 }