Glasgow | 26-ITP-Jan| Martin McLean |Sprint 3|Quote Generator#1030
Open
mjm-git185 wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 26-ITP-Jan| Martin McLean |Sprint 3|Quote Generator#1030mjm-git185 wants to merge 7 commits intoCodeYourFuture:mainfrom
mjm-git185 wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
mjm-git185
changed the title
mjm-git185
added
the
Needs Review
cjyuan
reviewed
Mar 26, 2026
| <script defer src="quotes.js"></script> | ||
| </head> | ||
|
|
||
| <body onload="pickNewQuoteToDisplay()"> |
Contributor
There was a problem hiding this comment.
Suggestion: Look up
Pros and cons between these two approaches to call a function,
callback(), on page load?
<body onload="callback()">in HTML codewindows.addEventListener("load", callback)in JS code
Comment on lines
+11
to
+12
| document.getElementById("quote").innerHTML = "'" + quoteForDisplay + "'"; | ||
| document.getElementById("author").innerHTML = ":-" + authorForDisplay; |
Contributor
There was a problem hiding this comment.
Suggestion: Look up
The differences between using
.innerHTML,innerText, andtextContentto set text content of an HTML element.
cjyuan
added
Reviewed
mjm-git185
added
the
Needs Review
cjyuan
reviewed
Mar 26, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Instead of placing all the "run on load' code in multiple places:
(1) This function call:
<body onload="pickNewQuoteToDisplay()">
and
(2) Code that setup the event listener:
.getElementById("new-quote")
.addEventListener("click", pickNewQuoteToDisplay);
can you practice placing all the "run on load" code inside a function?
Doing so can make it clearer that "this is what runs when the page loads."
For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
cjyuan
removed
the
Needs Review
Author
|
i have made the change to the setUp on load it seems far more readable like this thanks |
mjm-git185
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework