London | 26-ITP-January | Mouawia Elkhalifa | Sprint 3 | Todo list #1098
Open
MouawiaElkhalifa wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Mouawia Elkhalifa | Sprint 3 | Todo list #1098MouawiaElkhalifa wants to merge 5 commits intoCodeYourFuture:mainfrom
MouawiaElkhalifa wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
MouawiaElkhalifa
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
MouawiaElkhalifa
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
MouawiaElkhalifa
force-pushed
the
coursework/sprint-3-todo-list
branch
from
be8ee45 to
f751313
Compare
MouawiaElkhalifa
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
MouawiaElkhalifa
force-pushed
the
coursework/sprint-3-todo-list
branch
from
f751313 to
2295841
Compare
MouawiaElkhalifa
added
the
Needs Review
Luro91
reviewed
Apr 6, 2026
| "description": "You must update this package", | ||
| "type": "module", | ||
| "scripts": { | ||
| "serve": "http-server", |
There was a problem hiding this comment.
Why did you remove the script? I can not test the code with the npm run serve command
Author
There was a problem hiding this comment.
Hi, I’ve addressed the feedback.
Restored the serve script in package.json
Author
There was a problem hiding this comment.
"Hi, I have now pushed the restored serve script in package.json
| } | ||
|
|
||
| // Remove all tasks that are marked as completed§ | ||
| export function deleteCompleted(todos) { |
There was a problem hiding this comment.
I don't see a button that on the webpage where I can trigger this code
Author
There was a problem hiding this comment.
Hi, I’ve addressed the feedback.
Added a “Delete completed tasks” button to the UI
Connected the button to deleteCompleted(todos) so it removes completed tasks correctly
Luro91
added
Reviewed
MouawiaElkhalifa
added
Needs Review
Luro91
removed
the
Needs Review
MouawiaElkhalifa
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 7, 2026
Comment on lines
+32
to
+37
| for (let i = todos.length - 1; i >= 0; i--) { | ||
| if (todos[i].completed) { | ||
| todos.splice(i, 1); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The code works correctly. You can also research build in array funcitons that allow you to filter elements from an array
Luro91
removed
the
Review in progress
Luro91
added
the
Reviewed
Luro91
reviewed
Apr 7, 2026
Comment on lines
-11
to
-21
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/CodeYourFuture/CYF-Coursework-Template.git" | ||
| }, | ||
| "bugs": { | ||
| "url": "https://github.com/CodeYourFuture/CYF-Coursework-Template/issues" | ||
| }, | ||
| "homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme", | ||
| "devDependencies": { | ||
| "http-server": "^14.1.1", | ||
| "jest": "^30.0.4" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[x] I have titled my PR with London | 26-ITP-January | Mouawia Elkhalifa | Sprint 3 | Todo List
[x] My changes meet the requirements of the task
[x] I have tested my changes
[x] My changes follow the style guide
Changelist
In this PR, I have completed the Todo List exercised