Skip to content

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 2 | Module-Data-Groups#1099

Open
mshayriyesaricicek wants to merge 8 commits intoCodeYourFuture:mainfrom
mshayriyesaricicek:Sprint-2
Open

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 2 | Module-Data-Groups#1099
mshayriyesaricicek wants to merge 8 commits intoCodeYourFuture:mainfrom
mshayriyesaricicek:Sprint-2

Conversation

@mshayriyesaricicek
Copy link
Copy Markdown

@mshayriyesaricicek mshayriyesaricicek commented Mar 25, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Exercises for Sprint 2

@github-actions

This comment has been minimized.

Sign in to view
@mshayriyesaricicek mshayriyesaricicek changed the title Sheffield || ITP-Jan-26 || Hayriye Saricicek || Sprint 2 || Module-Data-Groups Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 2 | Module-Data-Groups Mar 25, 2026
@mshayriyesaricicek mshayriyesaricicek added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026
cjyuan
cjyuan reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating Sprint-2/interpret/invert.js.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 25, 2026
@mshayriyesaricicek mshayriyesaricicek mentioned this pull request Mar 30, 2026
Open
@mshayriyesaricicek mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 1, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 3, 2026

Explanation was clear and changes look good. Well done.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 3, 2026
@mshayriyesaricicek
Copy link
Copy Markdown
Author

mshayriyesaricicek commented Apr 5, 2026

HI, Thank you for reviewing. I cannot see anything on here that needs amending. Am I missing something or is it complete? Thank you.

@mshayriyesaricicek mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshayriyesaricicek @cjyuan