Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Data Groups#1103
Closed
Pretty548 wants to merge 1 commit intoCodeYourFuture:mainfrom
Closed
Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Data Groups#1103Pretty548 wants to merge 1 commit intoCodeYourFuture:mainfrom
Pretty548 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Pretty548
added
🏕 Priority Mandatory
cjyuan
reviewed
Mar 26, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
There is only one modified file on this PR branch. Have you pushed all your changes to GitHub?
| return median; | ||
| // Filter out non-numeric values and sort the remaining numbers | ||
| const numbers = list | ||
| .filter((x) => typeof x === "number" && !isNaN(x)) |
Contributor
There was a problem hiding this comment.
Do you plan to include Infinity and -Infinity in the calculation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Sprint 1 tasks including Fix, Implement, and Refactor sections.
Fixed calculateMedian to pass all tests and handle edge cases
Implemented findMax, sum, and dedupe functions
Ensured functions handle invalid input and mixed data types
Fixed floating point precision issue in sum
Refactored includes function to use a for...of loop
All tests are passing successfully