Skip to content

GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Alarm Clock #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcostaprakash wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Alarm Clock #1114

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e9cf7b
Test
dcostaprakash Mar 20, 2026
f5b39bd
GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Quote Generator
dcostaprakash Mar 27, 2026
bb109a1
Made changes as per the review
dcostaprakash Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,36 @@
function setAlarm() {}
let timeRemaining;
let timerId;
function setAlarm() {
const input = document.getElementById("alarmSet").value;
timeRemaining = Number(input);
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when the user enters a negative number or a string value?

Copy link
Copy Markdown
Author

@dcostaprakash dcostaprakash Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I see it is accepting negative and null inputs. I have made the change. Thank you for pointing it out


clearInterval(timerId);
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clearing of the interval to ensure only one countdown is running

Copy link
Copy Markdown
Author

@dcostaprakash dcostaprakash Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Thank you


updateDisplay();

timerId = setInterval(() => {
timeRemaining--;
updateDisplay();

if (timeRemaining <= 0) {
timeRemaining = 0;
updateDisplay();
clearInterval(timerId);
playAlarm();
}
}, 1000);
}
function updateDisplay() {
const display = document.getElementById("timeRemaining");

const minutes = Math.floor(timeRemaining / 60);
const seconds = timeRemaining % 60;

const formattedMinutes = String(minutes).padStart(2, "0");
const formattedSeconds = String(seconds).padStart(2, "0");

display.textContent = `Time Remaining: ${formattedMinutes}:${formattedSeconds}`;
}

// DO NOT EDIT BELOW HERE

Expand Down
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>AlarmClock</title>
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title should be "Alarm clock app"

Copy link
Copy Markdown
Author

@dcostaprakash dcostaprakash Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I made the change.

</head>
<body>
<div class="centre">
Expand Down
Loading