London | 26-ITP-Jan | Xuanming Hu | Sprint 3 | Alarm Clock App#1115
Open
Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Xuanming Hu | Sprint 3 | Alarm Clock App#1115Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
Samual-Hu
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 4, 2026
|
|
||
| let timeRemaining = parseInt(inputElement.value, 10) || 0; | ||
|
|
||
| clearInterval(countdownInterval); |
There was a problem hiding this comment.
Nice that the old interval is cleared when the alarm is set again
Sprint-3/alarmclock/alarmclock.js
Outdated
| countdownInterval = setInterval(() => { | ||
| timeRemaining--; | ||
|
|
||
| if (timeRemaining < 0) { |
There was a problem hiding this comment.
When does the alarm start when you are comparing for < 0 ?
Author
There was a problem hiding this comment.
Using '< 0' makes the alarm trigger one second late. I have updated it to '<= 0'. Thanks
Luro91
added
Reviewed
Samual-Hu
added
Needs Review
Author
|
Hi @Luro91, I have updated the code based on your feedback. |
Luro91
added
Reviewed
Luro91
reviewed
Apr 7, 2026
Comment on lines
+23
to
+24
| clearInterval(countdownInterval); | ||
| playAlarm(); |
There was a problem hiding this comment.
What does the countdown show when the alarm plays?
Author
There was a problem hiding this comment.
Because updateDisplay() was inside the else block, the screen would freeze at 00:01 while the alarm played, never actually showing 00:00.
Samual-Hu
added
Needs Review
Author
|
Hi @Luro91 , I have updated the display first before checking the |
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
setAlarmwithsetInterval.padStart.Questions
N/A