London | 26-ITP-Jan | Xuanming Hu | Sprint 3 | Quote Generator App#1116
Open
Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Xuanming Hu | Sprint 3 | Quote Generator App#1116Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Samual-Hu wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
Samual-Hu
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 6, 2026
Sprint-3/quote-generator/quotes.js
Outdated
| const quoteText = document.getElementById("quote"); | ||
| const authorText = document.getElementById("author"); | ||
| const newQuoteBtn = document.getElementById("new-quote"); | ||
| const autoPlayCheckbox = document.getElementById("auto-play"); |
There was a problem hiding this comment.
I don't see a button on the html page to start the auto change
Author
There was a problem hiding this comment.
That was leftover code from an experimental auto-play feature I was playing around with. Since it wasn't part of the actual requirements, I removed it from the HTML but forgot to clean it up from the quotes.js file. I have removed the dead code. Thanks for catching that.
Luro91
added
Reviewed
Samual-Hu
added
Needs Review
Author
|
Hi @Luro91, the dead code has been cleaned up. |
Luro91
added
Complete
|
Well done. The code works as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
N/A