Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Sprint-1/fix/median.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,27 @@
// or 'list' has mixed values (the function is expected to sort only numbers).

function calculateMedian(list) {
if (!Array.isArray(list)) {
return null;
}

list = list.filter((value) => typeof value === "number");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to consider also -Infinity, Infinity, and NaN in the median calculation (and in the functions in implement/max.js and implement/sum.js)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to handle all type of input i changed the filter , using built in method of Number.isFinite(value) can handle all type of values.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not apply the change also to findMax() and sum()?


if (list.length === 0) {
return null;
}

list.sort((a, b) => a - b);

const middleIndex = Math.floor(list.length / 2);
const median = list.splice(middleIndex, 1)[0];
return median;

if (list.length % 2 === 0) {
return (list[middleIndex - 1] + list[middleIndex]) / 2;
} else {
const middleIndex = Math.floor(list.length / 2);
Comment thread
cjyuan marked this conversation as resolved.
Outdated
const median = list.splice(middleIndex, 1)[0];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the same syntax you were using on line 24 to access an array element?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was writing the codes each one by one that why i forgot to combine them and some times little bit confusing putting line of codes together if you have any recommendation of books or techniques that i can read that would be helpful. thank you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the implemented function is working correctly, we should refactor our code to further improve the code. The process involves reviewing the code carefully, and reading code is a skill that takes time to develop (through reading and writing more code).

If you want something to read, you can try https://javascript.info/

return median;
}
}

module.exports = calculateMedian;
14 changes: 13 additions & 1 deletion Sprint-1/implement/dedupe.js
Original file line number Diff line number Diff line change
@@ -1 +1,13 @@
function dedupe() {}
function dedupe(arr) {
if (arr.length === 0) {
return [];
}
if (arr.length !== new Set(arr).size) {
const cleanedArray = [...new Set(arr)];
return cleanedArray;
} else {
return arr;
}
}

module.exports = dedupe;
29 changes: 27 additions & 2 deletions Sprint-1/implement/dedupe.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,37 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2]
// Given an empty array
// When passed to the dedupe function
// Then it should return an empty array
test.todo("given an empty array, it returns an empty array");
test("given an empty array, it returns an empty array", () => {
expect(dedupe([])).toEqual([]);
});

// Given an array with no duplicates
// When passed to the dedupe function
// Then it should return a copy of the original array

test("The function should return a copy of the original array if the array contains no duplicates", () => {
expect(dedupe([2, 4, 5, 6, 8])).toEqual([2, 4, 5, 6, 8]);
expect(dedupe([3, 7, 5, 8, 14, 19])).toEqual([3, 7, 5, 8, 14, 19]);
expect(dedupe(["apple", "banana", "milk", "egg"])).toEqual([
"apple",
"banana",
"milk",
"egg",
]);
});
Comment thread
cjyuan marked this conversation as resolved.
Comment on lines +26 to +38
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a chance that, even though the return value has incorrect elements (for example, [2, 2, 2, 2, 2]),
the two tests could still pass. Can you figure out why, and then fix the tests accordingly?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did some fixation now it is improved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not about how many sets of data you are testing, the issue in "how" you carry out the test.

Don't think how you implement your function. Think about under what condition a buggy function that returns [2, 2, 2, 2, 2] can possibly pass the test.

// Given an array with strings or numbers
// When passed to the dedupe function
// Then it should remove the duplicate values, preserving the first occurence of each element
test("The function should return a clean array when a duplicated array is passed", () => {
expect(dedupe([2, 2, 4, 4, 5, 5, 6, 6, 6, 6, 8, 8, 8, 8])).toEqual([
2, 4, 5, 6, 8,
]);
expect(dedupe([1, 1, 1, 2, 2, 3, 3, 4, 4, 6, 6, 7, 7, 8])).toEqual([
1, 2, 3, 4, 6, 7, 8,
]);
expect(
dedupe(["ahmed", "ahmed", "chris", "chris", "tom", "tom", "joy"])
).toEqual(["ahmed", "chris", "tom", "joy"]);
expect(
dedupe([2, 2, "apple", "apple", 5, 5, "samsung", "samsung", 8, 8])
).toEqual([2, "apple", 5, "samsung", 8]);
});
16 changes: 16 additions & 0 deletions Sprint-1/implement/max.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
function findMax(elements) {
if (elements.length === 0) {
return -Infinity;
}

const number = elements.filter((value) => typeof value === "number");

if (number.length === 0) {
return undefined;
}
let maxNumber = number[0];
for (let i = 1; i < number.length; i++) {
if (number[i] > maxNumber) {
maxNumber = number[i];
}
}
return maxNumber;
}

module.exports = findMax;
35 changes: 32 additions & 3 deletions Sprint-1/implement/max.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,57 @@ const findMax = require("./max.js");
// When passed to the max function
// Then it should return -Infinity
// Delete this test.todo and replace it with a test.
test.todo("given an empty array, returns -Infinity");
test("the function should return -Infinity when an empty array is passed to the function", () => {
expect(findMax([])).toEqual(-Infinity);
});

// Given an array with one number
// When passed to the max function
// Then it should return that number

test("The function should return the original value when an array with one number is passed", () => {
expect(findMax([17])).toBe(17);
expect(findMax([8])).toBe(8);
expect(findMax([4])).toBe(4);
});
// Given an array with both positive and negative numbers
// When passed to the max function
// Then it should return the largest number overall

test("The function should return the max value when an Integers number array is passed", () => {
expect(findMax([-3, -1, 0, 1, 3, 4, 6, 7])).toBe(7);
expect(findMax([-17, -8, -5, 2, 3, 0, 1])).toBe(3);
expect(findMax([-27, 18, -16, -9, 1, 7, 9])).toBe(18);
});
// Given an array with just negative numbers
// When passed to the max function
// Then it should return the closest one to zero
test("The function should return the closest one to zero when an negative number array is passed", () => {
expect(findMax([-3, -1, -4, -6, -7])).toBe(-1);
expect(findMax([-17, -8, -5, -2, -3])).toBe(-2);
expect(findMax([-27, -18, -32, -67, -78, -70])).toBe(-18);
});

// Given an array with decimal numbers
// When passed to the max function
// Then it should return the largest decimal number
test("The function should return the closest one to zero when an negative number array is passed", () => {
expect(findMax([3.5, 1.9, 5.4, 0.6, 3.7])).toBe(5.4);
expect(findMax([1.7, 0.8, 2.532, 1.092, 0.3])).toBe(2.532);
expect(findMax([0.27, 0.18, 0.32, 0.67, 0.78, 0.7])).toBe(0.78);
});

// Given an array with non-number values
// When passed to the max function
// Then it should return the max and ignore non-numeric values
test("The function should return the closest one to zero when an negative number array is passed", () => {
expect(findMax([3.5, "Leeds", "London", 3.7])).toBe(3.7);
expect(findMax(["italy", 0.8, 0.88, 0.89, "base"])).toBe(0.89);
expect(findMax([0.27, "jerry", 0.32, "apple", 0.78, "fly"])).toBe(0.78);
});
Comment thread
cjyuan marked this conversation as resolved.

// Given an array with only non-number values
// When passed to the max function
// Then it should return the least surprising value given how it behaves for all other inputs
test("the function should return undefined when non-number value is passed", () => {
expect(findMax(["Manchester", "Leeds", "London"])).toBe(undefined);
expect(findMax(["orange", "apple", "banana"])).toBe(undefined);
});
15 changes: 14 additions & 1 deletion Sprint-1/implement/sum.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
function sum(elements) {
}
if (elements.length === 0) {
return 0;
}
const number = elements.filter((value) => typeof value === "number");
if (number.length === 0) {
return undefined;
}
let sum = 0;
for (let i = 0; i < number.length; i++) {
sum += number[i];
}

return sum;
}
console.log(sum([]));
Comment thread
cjyuan marked this conversation as resolved.
Outdated
module.exports = sum;
40 changes: 35 additions & 5 deletions Sprint-1/implement/sum.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,54 @@ const sum = require("./sum.js");
// Given an empty array
// When passed to the sum function
// Then it should return 0
test.todo("given an empty array, returns 0")
test("The function should return 0 when an empty array is passed", () => {
expect(sum([])).toEqual(0);
});

// Given an array with just one number
// When passed to the sum function
// Then it should return that number

test("The function should return single value when single value array is passed", () => {
expect(sum([7])).toEqual(7);
expect(sum([14])).toEqual(14);
expect(sum([0])).toEqual(0);
expect(sum([100])).toEqual(100);
});
// Given an array containing negative numbers
// When passed to the sum function
// Then it should still return the correct total sum

test("The function should return the correct total value when negative number array is passed", () => {
expect(sum([-7, -10, -33])).toEqual(-50);
expect(sum([-6, -10, -18, -4])).toEqual(-38);
expect(sum([-100, -10, -1, -20])).toEqual(-131);
expect(sum([-12, -23, -34, -45, -56, -67])).toEqual(-237);
});
// Given an array with decimal/float numbers
// When passed to the sum function
// Then it should return the correct total sum

test("The function should return the correct total value when decimal/float numbers array is passed", () => {
expect(sum([7.8045, 1.273, 3.19])).toEqual(12.2675);
expect(sum([4.6, 1.8, 3.18, 5.4])).toEqual(14.98);
expect(sum([11 / 12, 4 / 6, 1 / 2, 6 / 20])).toEqual(2.383333333333333);
expect(sum([1 / 2, 2 / 3, 3 / 4, 4 / 5, 5 / 6, 6 / 7])).toEqual(
4.4071428571428575
);
Comment on lines +42 to +48
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specify different "number of decimal places" in your tests?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the more decimal places I expected value has, the stricter my test needs to be.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just enforce the strictest tolerable difference?

If the function can pass this test
expect(sum([7.8045, 1.273, 3.19])).toBeCloseTo(12.2675, 9);
then the function will also pass
expect(sum([7.8045, 1.273, 3.19])).toBeCloseTo(12.2675, 4);

For adding only a few numbers, the rounding error will be very small. So it's ok to be strict.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i will implement that in fact in this test i did that the test go through all the decimal numbers until the end that's why i specified each decimal number to test.

});
Comment thread
cjyuan marked this conversation as resolved.
// Given an array containing non-number values
// When passed to the sum function
// Then it should ignore the non-numerical values and return the sum of the numerical elements

test("The function should return the correct total value when an array containing non-number values is passed", () => {
expect(sum([7.8045, "two", 3.19])).toEqual(10.9945);
expect(sum(["one", 1.8, 3.18, "zero"])).toEqual(4.98);
expect(sum([1 / 12, 4 / 6, "Ahmed", 6 / 8])).toEqual(1.5);
expect(sum(["one", "two", "three", "four", "five", 1 / 2])).toEqual(0.5);
});
// Given an array with only non-number values
// When passed to the sum function
// Then it should return the least surprising value given how it behaves for all other inputs
test("The function should return undefined when an array with only non-number values is passed", () => {
expect(sum(["male", "two", "age"])).toEqual(undefined);
expect(sum(["one", "zero"])).toEqual(undefined);
expect(sum(["world", "apple", "Ahmed", "london"])).toEqual(undefined);
expect(sum(["one", "two", "three", "four", "five"])).toEqual(undefined);
});
3 changes: 1 addition & 2 deletions Sprint-1/refactor/includes.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Refactor the implementation of includes to use a for...of loop

function includes(list, target) {
for (let index = 0; index < list.length; index++) {
const element = list[index];
for (let element of list) {
if (element === target) {
return true;
}
Expand Down
Loading