-
-
Notifications
You must be signed in to change notification settings - Fork 279
Manchester | 26-ITP-Jan | Abdu Hassen | Sprint 2| Data-Grouping #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abduhasen
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
Abduhasen:Data-Group-sprint-2-backlog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| function contains() {} | ||
| function contains(targetObject, searchTerm) { | ||
| if ( | ||
| typeof targetObject !== "object" || | ||
| Object.keys(targetObject).length === 0 || | ||
| Array.isArray(targetObject) | ||
| ) { | ||
| return false; | ||
| } | ||
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| for (const property in targetObject) { | ||
| if (targetObject[property] === searchTerm || property === searchTerm) { | ||
| return true; | ||
| } | ||
| } | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return false; | ||
| } | ||
| console.log(contains(["a", "b", "c"], "d")); | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| module.exports = contains; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,16 +20,37 @@ as the object doesn't contains a key of 'c' | |
| // Given an empty object | ||
| // When passed to contains | ||
| // Then it should return false | ||
| test.todo("contains on empty object returns false"); | ||
| test("The function should return undefined when an empty object is passed to it.", () => { | ||
| expect(contains({})).toBe(false); | ||
| }); | ||
|
|
||
| // Given an object with properties | ||
| // When passed to contains with an existing property name | ||
| // Then it should return true | ||
| test("The function should return true when the object contains the targeted property", () => { | ||
| expect(contains({ town: "leeds" }, "leeds")).toBe(true); | ||
| expect(contains({ a: 1, b: 2, c: 3 }, "a")).toBe(true); | ||
| expect(contains({ name: "ahmed", sex: "male", age: 29 }, "male")).toBe(true); | ||
| expect(contains({ zone: 2, zone: 3, zone: 4 }, "zone")).toBe(true); | ||
| }); | ||
|
|
||
| // Given an object with properties | ||
| // When passed to contains with a non-existent property name | ||
| // Then it should return false | ||
| test("the function should return false when the targeted property don't exist", () => { | ||
| expect(contains({ a: 1, b: 2, c: 3 }, "d")).toBe(false); | ||
| expect(contains({ year: 1998, month: 10, Date: 16 }, "age")).toBe(false); | ||
| expect(contains({ meal: "pizza", drink: "water", table: 3 }, "starter")).toBe( | ||
| false | ||
| ); | ||
| }); | ||
|
|
||
| // Given invalid parameters like an array | ||
| // When passed to contains | ||
| // Then it should return false or throw an error | ||
| test("the function should return false when invalid parameter like an array is passed", () => { | ||
| expect(contains([10, 23, 34, 45], 45)).toBe(false); | ||
| expect(contains("hello", "hi")).toBe(false); | ||
|
||
| expect(contains(["green", "yellow", "rad"], "green")).toBe(false); | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect(contains(((30, 40, 50), 30))).toBe(false); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function createLookup() { | ||
| function createLookup(arrayOfArrays) { | ||
| // implementation here | ||
| const lookUpObject = {}; | ||
| for (const innerArray of arrayOfArrays) { | ||
| keyPair = innerArray[0]; | ||
| valuePair = innerArray[1]; | ||
| lookUpObject[keyPair] = valuePair; | ||
| } | ||
| return lookUpObject; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| function tally() {} | ||
| function tally(myArray) { | ||
| if (myArray.length === 0) { | ||
| return {}; | ||
| } else if (typeof myArray === "string") { | ||
| throw Error; | ||
| } | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| let tallyObject = {}; | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| for (const singleItems of myArray) { | ||
| if (tallyObject[singleItems] === undefined) { | ||
| tallyObject[singleItems] = 1; | ||
| } else { | ||
| tallyObject[singleItems] += 1; | ||
| } | ||
| } | ||
| return tallyObject; | ||
| } | ||
|
|
||
| module.exports = tally; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.