Skip to content
Open
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cb3d8e0
Jest test for first case
AngelaMcLeary Mar 6, 2026
20843ce
completed dedupe.js and dedupe.test.js formatted with prettier
AngelaMcLeary Mar 7, 2026
4d92ad9
add first 3 Jest tests to max.test.js
AngelaMcLeary Mar 7, 2026
0be6961
add all Jest tests to max.test.js
AngelaMcLeary Mar 7, 2026
d95136c
impemented code for mdeian.js and tested against median.test.js
AngelaMcLeary Mar 10, 2026
a0c1ced
implemented first version of max.js
AngelaMcLeary Mar 10, 2026
c938555
fixed max,js implementation, complted sum.js
AngelaMcLeary Mar 12, 2026
5e3891a
formatted code with prettier
AngelaMcLeary Mar 15, 2026
dbbd297
Merge branch 'main' into Sprint-1
AngelaMcLeary Mar 28, 2026
165c3cb
updated files after pull request
AngelaMcLeary Mar 28, 2026
98dbe4f
update implementation in median.js to handle Infinity,-Infinity and …
AngelaMcLeary Apr 5, 2026
7ad87e2
update implementation in max.js to handle Infinity,-Infinity and NaN…
AngelaMcLeary Apr 5, 2026
721b34f
update implementation in sum.js to handle Infinity,-Infinity and NaN…
AngelaMcLeary Apr 5, 2026
394f6d0
update comments
AngelaMcLeary Apr 6, 2026
fd87459
update implamentation median.js to validate values
AngelaMcLeary Apr 6, 2026
f68c1a6
update test to value equality
AngelaMcLeary Apr 6, 2026
0fd7113
update max.test.js to include test for numbers which are strings
AngelaMcLeary Apr 6, 2026
3151ec4
update test in sum.test.js to handle decimals using toBeClose
AngelaMcLeary Apr 6, 2026
22155ff
update and improve test in dedupe.test.js
AngelaMcLeary Apr 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions Sprint-1/fix/median.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,50 @@
// or 'list' has mixed values (the function is expected to sort only numbers).

function calculateMedian(list) {
const middleIndex = Math.floor(list.length / 2);
const median = list.splice(middleIndex, 1)[0];
return median;
}
if (!Array.isArray(list) || list.length === 0) return null;
//If the items are not an array or if the array is empty return null
const isItANumber = list.map((value) => {
if (value === null || value === undefined) {
return NaN;
}
//checks for null and undefined and ignore them.

if (typeof value === "number") {
return value;
}
// check for actual numbers and keep them.

return NaN;
});
//everything else is NaN.

const numbers = isItANumber.filter((num) => Number.isFinite(num));
if (numbers.length === 0) return null;
//checks the array before sorting and removing anything that is not a valid items and excludes NaN, Infinity and -Infinity.
const sortedList = [...numbers].sort((a, b) => a - b);
Comment thread
cjyuan marked this conversation as resolved.
//Sorts the numbers without modifying the original array. This is useful but not always necessary.
const middleIndex = Math.floor(sortedList.length / 2);
//finds the median position
if (sortedList.length % 2 === 0) {
// if the list length is even, average the two middle numbers
return (sortedList[middleIndex - 1] + sortedList[middleIndex]) / 2;
//It finds the middles of the array and selects the number before the middle and and adds the next number then divides by 2 when number is even.
}
return sortedList[middleIndex];
//if it is odd it returns the middle number
}
//checking
// console.log(calculateMedian([1, 2, "3", null, undefined, 4])); // 2
// console.log(calculateMedian([1, 2, 3, 4])); // 2.5
// console.log(calculateMedian([110, 20, 0])); //20
// console.log(calculateMedian([1, "apple", 2, null, 5, undefined])); // 2
// console.log(calculateMedian("not array")); // null
// console.log(calculateMedian("")); // null
module.exports = calculateMedian;

//check list
// Is the input valid? ie not a string?
//Validate what is valid input should be
// sort input and put in new array
//calculate median
//check output
22 changes: 17 additions & 5 deletions Sprint-1/fix/median.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ describe("calculateMedian", () => {
{ input: [1, 2, 3, 4], expected: 2.5 },
{ input: [1, 2, 3, 4, 5, 6], expected: 3.5 },
].forEach(({ input, expected }) =>
it(`returns the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
it(`returns the median for [${input}]`, () =>
expect(calculateMedian(input)).toEqual(expected))
);

[
Expand All @@ -24,7 +25,8 @@ describe("calculateMedian", () => {
{ input: [110, 20, 0], expected: 20 },
{ input: [6, -2, 2, 12, 14], expected: 6 },
].forEach(({ input, expected }) =>
it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
it(`returns the correct median for unsorted array [${input}]`, () =>
expect(calculateMedian(input)).toEqual(expected))
);

it("doesn't modify the input array [3, 1, 2]", () => {
Expand All @@ -33,8 +35,17 @@ describe("calculateMedian", () => {
expect(list).toEqual([3, 1, 2]);
});

[ 'not an array', 123, null, undefined, {}, [], ["apple", null, undefined] ].forEach(val =>
it(`returns null for non-numeric array (${val})`, () => expect(calculateMedian(val)).toBe(null))
[
"not an array",
123,
null,
undefined,
{},
[],
["apple", null, undefined],
].forEach((val) =>
it(`returns null for non-numeric array (${val})`, () =>
expect(calculateMedian(val)).toBe(null))
);

[
Expand All @@ -45,6 +56,7 @@ describe("calculateMedian", () => {
{ input: [3, "apple", 1, null, 2, undefined, 4], expected: 2.5 },
{ input: ["banana", 5, 3, "apple", 1, 4, 2], expected: 3 },
].forEach(({ input, expected }) =>
it(`filters out non-numeric values and calculates the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
it(`filters out non-numeric values and calculates the median for [${input}]`, () =>
expect(calculateMedian(input)).toEqual(expected))
);
});
23 changes: 22 additions & 1 deletion Sprint-1/implement/dedupe.js
Original file line number Diff line number Diff line change
@@ -1 +1,22 @@
function dedupe() {}
function dedupe(arr) {
if (arr.length === 0) {
//checks if array is empty
return arr;
};
const newArray = []; // to store the new values after checking and deduplicating
for (let i = 0; i < arr.length; i++) {
// checks every item in array for dupes
if (!newArray.includes(arr[i])) {
//checks if new item is already in newArray
newArray.push(arr[i]); // adds new item !in newArray and appends it
}
};
return newArray; // returns new array without duplicates/empty
};

// console.log(dedupe([])); // prints: []
// console.log(dedupe([1, 2, 3])); // prints: [ 1, 2, 3 ]
// console.log(dedupe([5, 1, 1, 2, 3, 2, 5, 8])); // prints: [ 5, 1, 2, 3, 8 ]
// console.log(dedupe(["a", "a", "a", "b", "b", "c"])); // prints: [ 'a', 'b', 'c' ]

module.exports = dedupe;
18 changes: 17 additions & 1 deletion Sprint-1/implement/dedupe.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,29 @@ E.g. dedupe([1, 2, 1]) returns [1, 2]
// Given an empty array
// When passed to the dedupe function
// Then it should return an empty array
test.todo("given an empty array, it returns an empty array");
test("given an empty array, it returns an empty array", () => {
expect(dedupe([])).toEqual([]);
});

// Given an array with no duplicates
// When passed to the dedupe function
// Then it should return a copy of the original array
test("given an array has no duplicates, it returns a copy of the original array", () => {
const originalArray = [1, 2, 3];
const result = dedupe(originalArray);
expect(result).toEqual(originalArray);
expect(result).not.toBe(originalArray);
Comment on lines +28 to +30
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test can verify the function can return a different array.

However, there is a chance that, even though result has incorrect elements (for example, [1, 1, 1]),
the test on line 29 could still pass. Can you figure out why, and then improve the test accordingly?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjyuan, Thanks for your feedback. I have done some research and understand that this only checks value equality, so it could still pass even if the function returns the same array or mutates it. Added checks to make sure a new array is returned and the original input isn't changed. I have added additional test.

});
Comment thread
cjyuan marked this conversation as resolved.

// Given an array of strings or numbers
// When passed to the dedupe function
// Then it should remove the duplicate values, preserving the first occurence of each element
test("given an array with strings or numbers, it removes the duplicates preserving the first occurrence of each element", () => {
expect(dedupe([5, 1, 1, 2, 3, 2, 5, 8])).toEqual([5, 1, 2, 3, 8]);
expect(dedupe([1, 2, 1])).toEqual([1, 2]);
expect(dedupe(["a", "a", "a", "b", "b", "c"])).toEqual(["a", "b", "c"]);
expect(dedupe(["z", "y", "w", "w", "u", "u"])).toEqual(["z", "y", "w", "u"]);
});
// Then it should return a new array with duplicates removed while preserving the
// first occurrence of each element from the original array.
// updated version
10 changes: 9 additions & 1 deletion Sprint-1/implement/max.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
function findMax(elements) {
}
if (!Array.isArray(elements)) return null;

if (elements.length === 0) return -Infinity;
// must include declaration for infinity or test fails.
const numbers = elements.filter((num) => Number.isFinite(num));
if (numbers.length === 0) return NaN;
// it returns NaN if no numbers found, there is no need to sort the numbers
return Math.max(...numbers);
}
//console.log(findMax([200, 5, 8, 15, 90, 12]));
module.exports = findMax;
25 changes: 24 additions & 1 deletion Sprint-1/implement/max.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,51 @@ const findMax = require("./max.js");
// When passed to the max function
// Then it should return -Infinity
// Delete this test.todo and replace it with a test.
test.todo("given an empty array, returns -Infinity");
test("given an empty array, it returns -Infinity", () => {
expect(findMax([])).toBe(-Infinity);
});

// Given an array with one number
// When passed to the max function
// Then it should return that number
test("given an array with one number, it returns that number", () => {
expect(findMax([1])).toEqual(1);
});

// Given an array with both positive and negative numbers
// When passed to the max function
// Then it should return the largest number overall
test("given an array with positive and negative numbers, it returns the largest overall number", () => {
expect(findMax([-5, 35, 15, -55])).toEqual(35);
});

// Given an array with just negative numbers
// When passed to the max function
// Then it should return the closest one to zero

test("given an array with just negative numbers, returns the closest to zero", () => {
expect(findMax([-55, -35, -15, -5])).toEqual(-5);
});

// Given an array with decimal numbers
// When passed to the max function
// Then it should return the largest decimal number

test("given an array with decimal numbers, it returns the largest decimal number", () => {
expect(findMax([5.5, 3.5, 1.5, 0.5])).toEqual(5.5);
});

// Given an array with non-number values
// When passed to the max function
// Then it should return the max and ignore non-numeric values

test("ignores non-number values and returns the max number", () => {
expect(findMax(["Not", "A", "Number", "300", 75, 85, 105])).toEqual(105);
});

Comment thread
cjyuan marked this conversation as resolved.
// Given an array with only non-number values
// When passed to the max function
// Then it should return the least surprising value given how it behaves for all other inputs
test("given an array with non-number values, returns Not a Number (NaN)", () => {
expect(findMax(["a", "b", "c"])).toBeNaN(); // note: NaN !== NaN,
});
11 changes: 11 additions & 0 deletions Sprint-1/implement/sum.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
function sum(elements) {
const numbers = elements.filter((num) => Number.isFinite(num));

if (numbers.length === 0 && elements.length > 0) return NaN;

return numbers.reduce((total, nextNumber) => total + nextNumber, 0);
}
// console.log(sum([])); // 0
// console.log(sum([1])); // 1
// console.log(sum([5, 2, -3])); //4
// console.log(sum([1.5, 2.5, 3.5])); //7.5
// console.log(sum(["h", 2.5, "e", 3.5])); //6
// console.log(sum(["a", "b", "c", "d"])); //Nan

module.exports = sum;
22 changes: 20 additions & 2 deletions Sprint-1/implement/sum.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,42 @@ const sum = require("./sum.js");
// Given an empty array
// When passed to the sum function
// Then it should return 0
test.todo("given an empty array, returns 0")
test("given an empty array, it returns 0", () => {
expect(sum([])).toEqual(0);
});

// Given an array with just one number
// When passed to the sum function
// Then it should return that number
test("given an array with just one number, it returns that number", () => {
expect(sum([1])).toEqual(1);
});

// Given an array containing negative numbers
// When passed to the sum function
// Then it should still return the correct total sum
test("given an array containing negative numbers, it returns the correct sum", () => {
expect(sum([5, 2, -3])).toEqual(4);
});

// Given an array with decimal/float numbers
// When passed to the sum function
// Then it should return the correct total sum

test("given an array with decimal float numbers, it should return the total sum", () => {
expect(sum([1.5, 2.5, 3.5])).toBeCloseTo(7.5);
});
Comment on lines +37 to +39
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decimal numbers in most programming languages (including JS) are internally represented in "floating point number" format. Floating point arithmetic is not exact. For example, the result of 46.5678 - 46 === 0.5678 is false because 46.5678 - 46 only yield a value that is very close to 0.5678. Even changing the order in which the program add/subtract numbers can yield different values.

So the following could happen

  expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.805 );                // This fail
  expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.8049999999999997 );   // This pass
  expect( 0.005 + 0.6 + 1.2 ).toEqual( 1.8049999999999997 );   // This fail

  console.log(1.2 + 0.6 + 0.005 == 1.805);  // false
  console.log(1.2 + 0.6 + 0.005 == 0.005 + 0.6 + 1.2); // false

Can you find a more appropriate way to test a value (that involves decimal number calculations) for equality?

Suggestion: Look up

  • Checking equality in floating point arithmetic in JavaScript
  • Checking equality in floating point arithmetic with Jest

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjyuan, Thank you for your feedback. I understand now why decimal values need special handling. toBeCloseTo() is a better choice because it checks that the result is close enough within a small margin, which avoids issues caused by floating‑point rounding.

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The default value of the second parameter of toBeCloseTo() is only 2
See: https://jestjs.io/docs/expect#tobeclosetonumber-numdigits

For the default value 2, the test criterion is Math.abs(expected - received) < 0.005, which may not be precise enough in some applications.

// Given an array containing non-number values
// When passed to the sum function
// Then it should ignore the non-numerical values and return the sum of the numerical elements
test("given an array containing non-number values, it should ignore the non-numbers and sum the numerical elements", () => {
expect(sum(["h", 2.5, "e", 3.5])).toEqual(6);
});

// Given an array with only non-number values
// When passed to the sum function
// Then it should return the least surprising value given how it behaves for all other inputs
test("given an array with non-number values, returns Not a Number (NaN)", () => {
expect(sum(["a", "b", "c"])).toBeNaN(); // note: NaN !== NaN,
});

//
Loading
Loading