London | 26-ITP-Jan | Angela McLeary | Sprint 3 | Alarm clock app #1134
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,80 @@ | ||
| let alarmInterval; | ||
| let colorInterval; | ||
|
|
||
| function setAlarm() { | ||
| clearInterval(alarmInterval); | ||
| const timeRemaining = document.querySelector("#alarmSet"); | ||
| const display = document.querySelector("#timeRemaining"); | ||
| if (!timeRemaining || !display) return; | ||
| //what ever we input is turned into seconds | ||
| let totalSeconds = parseInt(timeRemaining.value); | ||
|
|
||
| if (isNaN(totalSeconds) || totalSeconds <= 0) return; | ||
|
There was a problem hiding this comment. Nice input validation. How could you inform the users that the input was invalid?
Author
There was a problem hiding this comment. Hi @Luro91, Thank you for your feedback. I have updated the element by putting in a placeholder with shadowed text. I have also thrown in an error message which let's the user know what they need to do. |
||
|
|
||
| const formattedTime = (seconds) => { | ||
| const mins = Math.floor(seconds / 60) | ||
| .toString() | ||
| .padStart(2, "0"); | ||
| const secs = (seconds % 60).toString().padStart(2, "0"); | ||
| return `${mins}:${secs}`; | ||
| }; | ||
|
|
||
| display.innerHTML = `Time Remaining: ${formattedTime(totalSeconds)}`; | ||
|
|
||
| alarmInterval = setInterval(() => { | ||
| totalSeconds--; | ||
|
|
||
| display.innerHTML = `Time Remaining: ${formattedTime(totalSeconds)}`; | ||
|
|
||
| if (totalSeconds <= 0) { | ||
| clearInterval(alarmInterval); | ||
| playAlarm(); | ||
| } | ||
| }, 1000); | ||
| } | ||
| //add color changing background when alarm reaches 0 until stopped. | ||
| //function from color changing assignment 10 year ago! | ||
| function makeRandomColor() { | ||
| let colorOptions = "0123456789ABCDEF"; | ||
| let newColor = "#"; | ||
| //repeat 6 times to generate 6 random hex digits from the 16 characters in colorOptions | ||
| for (let i = 0; i < 6; i++) { | ||
| //picks random numbers from colorOptions and appends it to the # to make a new color. | ||
| newColor += colorOptions[Math.floor(Math.random() * 16)]; | ||
| } | ||
| return newColor; | ||
| } | ||
| //end color changing | ||
|
|
||
| //keep the existing code below and call the setup | ||
| //set the background color transition | ||
| document.body.style.transition = "background-color 0.7s ease"; | ||
| // call the entire page | ||
| window.addEventListener("load", function () { | ||
|
There was a problem hiding this comment. Nice that you did the extension task with changing colors |
||
| // attach the alarm sound to the make Random color so it starts changing when the alarm starts. | ||
| audio.addEventListener("play", () => { | ||
| // stops any previous color changing intervals | ||
| clearInterval(colorInterval); | ||
| //starts a new repeating timer and saves it's ID in colorInterval. setInterval runs every 2seconds | ||
| colorInterval = setInterval(() => { | ||
| //style the background and make it important! so it over-rides the style.css | ||
| document.body.style.setProperty( | ||
| "background-color", | ||
| makeRandomColor(), | ||
| "important" | ||
| ); | ||
| //closes setInterval after 1 seconds | ||
| }, 1000); | ||
| }); | ||
|
|
||
| audio.addEventListener("pause", () => { | ||
| clearInterval(colorInterval); | ||
| document.body.style.backgroundColor = ""; | ||
| }); | ||
| }); | ||
| //not sure that this is helping. The function works without it. | ||
| window.setAlarm = setAlarm; | ||
|
There was a problem hiding this comment. You don't need to attach the function to the window object as the function is already declared in the file and available here in this file
Author
There was a problem hiding this comment. Hi @Luro91, Thank you for your feedback. I have removed it. |
||
| //end linking | ||
|
|
||
| // DO NOT EDIT BELOW HERE | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you clear the interval here so that the running countdown is stopped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Luro91, Thank you for your feedback.