London | 26-ATP-Jan | Boualem Larbi Djebbour | sprint 3 | Alarm clock app#1144
Open
djebsoft wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ATP-Jan | Boualem Larbi Djebbour | sprint 3 | Alarm clock app#1144djebsoft wants to merge 7 commits intoCodeYourFuture:mainfrom
djebsoft wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
djebsoft
added
the
Needs Review
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
djebsoft
changed the title
djebsoft
added
the
Needs Review
djebsoft
changed the title
Luro91
added
Review in progress
Luro91
reviewed
Apr 6, 2026
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
+9
to
+10
| let seconds = 0; | ||
| let minutes = 0; |
There was a problem hiding this comment.
It's good practice to only use one data property and derive information from it. How could you change your code to only use one variable to keep track of the time?
Luro91
added
Reviewed
djebsoft
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
… user types in the input field." This reverts commit adf628a.
…e user types in the input field.
djebsoft
added
the
Needs Review
Luro91
added
Review in progress
|
Well Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
buildin the Alarn clock app.
Questions