Manchester | ITP-Jan-26 | Khalidbih | Sprint 3 | Alarm Clock#1150
Open
khalidbih wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Manchester | ITP-Jan-26 | Khalidbih | Sprint 3 | Alarm Clock#1150khalidbih wants to merge 2 commits intoCodeYourFuture:mainfrom
khalidbih wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A-O-Emmanuel
reviewed
Apr 4, 2026
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
This is a good attempt, however:
- The form field accepts negative numbers, It should not
- When the form field is empty and I click set alarm, the alarm sound goes off, the sound should not go off with an empty form field.
These are the things I observed and I think should be fixe, still good job!
Author
Thank you for the feedback! I've updated the alarm clock to prevent negative numbers and to ignore empty inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Complete implementation of the alarm clock with countdown timer and sound alert.