Sheffield | 26-ITP-jan | Karim M'hamdi| Sprint 3 | Alarm Clock#1164
Open
KKtech06 wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-jan | Karim M'hamdi| Sprint 3 | Alarm Clock#1164KKtech06 wants to merge 5 commits intoCodeYourFuture:mainfrom
KKtech06 wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
KKtech06
added
the
Needs Review
A-O-Emmanuel
added
Review in progress
A-O-Emmanuel
reviewed
Apr 4, 2026
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
This is a good attempt, but I noticed these things:
- The input field accepts negative numbers and that also triggers the alarm
- The alarm goes of when I click
set alarmeven without entering any number in the input field.
A-O-Emmanuel
added
Reviewed
…ground colour to make it stand better
KKtech06
added
Needs Review
Author
|
Thank you for the feedback I have fixed the issues and plus I have changed the background colour to make the Alarm Clock look better Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist: I have build a working Alarm Clock using HTML/ CSS to design it and to make it function i have used JavaScript
Questions
N/A