Skip to content

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Alarm clock #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marthak1 wants to merge 5 commits into
base: main
Choose a base branch
from
+53 −2
Open

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Alarm clock #1167

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed3d3cc
update html title, convert input value to time format and set dynamic…
marthak1 Apr 3, 2026
0d11d74
changed html title using js queryselector
marthak1 Apr 3, 2026
44f98d7
update alarm logic and removed unused comments
marthak1 Apr 3, 2026
8c9db65
update htlm title in html file
marthak1 Apr 6, 2026
2a0eef7
function updated to disallow multiple timers and validate input
marthak1 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@
function setAlarm() {}
const title = document.querySelector('title')
title.textContent = "Alarm clock app";
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you undo the change where you changed the title in the HTML first?

Copy link
Copy Markdown
Author

@marthak1 marthak1 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I originally changed the title via the DOM to practice DOM manipulation, but I’ve now updated it in the HTML file to match the requirements.

function time_convert(num) {
let minutes = Math.floor((num % 3600) / 60);
let seconds = num % 60;
return minutes.toString().padStart(2, '0') + ":" + seconds.toString().padStart(2, '0');
}
function setAlarm() {
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a user clicks the set alarm button while the countdown is already running?

Copy link
Copy Markdown
Author

@marthak1 marthak1 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Function has now been updated to stop multiple timers

const alarmSetInputEl = document.getElementById("alarmSet");
let timeEl = Number(alarmSetInputEl.value);
Copy link
Copy Markdown

@Luro91 Luro91 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the user enters a negative number or a non number string?

Copy link
Copy Markdown
Author

@marthak1 marthak1 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, Function now updated to validate input.

const timeRemainingCounterEl = document.getElementById("timeRemaining");
const interval = setInterval(() => {
timeEl--;

timeRemainingCounterEl.textContent = `Time Remaining: ${time_convert(timeEl)}`;

if (timeEl <= 0) {
clearInterval(interval);
timeRemainingCounterEl.textContent = "Done!";
playAlarm();
}
}, 1000);
}


// DO NOT EDIT BELOW HERE

Expand All @@ -23,3 +46,4 @@ function pauseAlarm() {
}

window.onload = setup;

1 change: 1 addition & 0 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ <h1 id="timeRemaining">Time Remaining: 00:00</h1>
<script src="alarmclock.js"></script>
</body>
</html>

Loading