London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Data Groups#1190
Open
miriamjorna wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Data Groups#1190miriamjorna wants to merge 7 commits intoCodeYourFuture:mainfrom
miriamjorna wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
miriamjorna
added
📅 Sprint 2
cjyuan
reviewed
Apr 11, 2026
cjyuan
added
Reviewed
miriamjorna
added
the
Needs Review
cjyuan
reviewed
Apr 16, 2026
Comment on lines
+6
to
+11
| for (const item of arr) { | ||
| if (Object.hasOwn(result, item)) { | ||
| result[item]++; | ||
| } else { | ||
| result[item] = 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Indentation is off.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
If you have successfully setup VSCode, you won't need to worry about manual indentation or trailing space.
Author
There was a problem hiding this comment.
Thank you, this one is now also Prettified :)
cjyuan
removed
the
Needs Review
miriamjorna
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Coursework for Sprint 2.
My mojo went MIA but I've found it back!