Skip to content

West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Reading List #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Baba05206 wants to merge 9 commits into from
Closed

West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Reading List #901

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
11e30f5
Add initial implementation of mean calculation and tests
Baba05206 Nov 6, 2025
3cb29a0
Refactor mean calculation and tests for clarity and functionality
Baba05206 Nov 7, 2025
3d4c407
Update mean.js
Baba05206 Nov 18, 2025
17dea8e
deleted prep
Nov 29, 2025
805fee7
Merge branch 'main' of https://github.com/Baba05206/Module-Data-Groups
Baba05206 Nov 30, 2025
d71a842
Refactor reading list functionality and update styles for read/unread…
Baba05206 Nov 30, 2025
2bbaaf3
Remove unnecessary comment in readingList function
Baba05206 Nov 30, 2025
e813e11
handled null or undefined book variable. returns helpful message
Baba05206 Dec 8, 2025
038c26a
improved the look and feel of the reading-list page. modified contras…
Baba05206 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sprint-3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "CC-BY-SA-4.0",
"description": "",
"scripts": {
"test": "jest",
"test": "jest --config=../jest.config.js reading-list",
"format": "prettier --write ."
},
"workspaces": [
Expand All @@ -26,7 +26,7 @@
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/user-event": "^14.6.1",
"jest": "^30.0.4",
"jest": "^30.2.0",
"jest-environment-jsdom": "^30.0.4"
}
}
4 changes: 2 additions & 2 deletions Sprint-3/reading-list/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE >
<!DOCTYPE html>
<html lang="en_US">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Reading list app</title>
</head>
<body>
<div id="content">
Expand Down
7 changes: 5 additions & 2 deletions Sprint-3/reading-list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "CC-BY-SA-4.0",
"description": "You must update this package",
"scripts": {
"test": "jest --config=../jest.config.js reading-list"
"test": "jest"
},
"repository": {
"type": "git",
Expand All @@ -13,5 +13,8 @@
"bugs": {
"url": "https://github.com/CodeYourFuture/CYF-Coursework-Template/issues"
},
"homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme"
"homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme",
"devDependencies": {
"@testing-library/jest-dom": "^6.9.1"
}
}
24 changes: 24 additions & 0 deletions Sprint-3/reading-list/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,28 @@ const books = [
bookCoverImage: "https://blackwells.co.uk/jacket/l/9780135957059.jpg",
},
];
function readingList() {
const unorderedList = document.querySelector("#reading-list");

for (const book of books) {
Copy link
Copy Markdown

@JaypeeLan JaypeeLan Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a base condition, if book is empty, so your application does not crash.

Copy link
Copy Markdown
Author

@Baba05206 Baba05206 Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @JaypeeLan. I have now updated the script to check if the books variable is null or undefined, or if the array is empty. Will return message telling the user their reading list is empty

Copy link
Copy Markdown

@JaypeeLan JaypeeLan Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baba05206 Please go through the conversations, I made a comment regarding the design.

const newList = document.createElement("li");

const newImage = document.createElement("img");
newImage.src = book.bookCoverImage;

const paragraph = document.createElement("p");
paragraph.textContent = `${book.title} by ${book.author}`;

newList.append(paragraph, newImage);

if (book.alreadyRead) {
newList.classList.add("read");
} else {
newList.classList.add("notRead");
}

unorderedList.appendChild(newList);
}
}

readingList();
7 changes: 4 additions & 3 deletions Sprint-3/reading-list/script.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
require("@testing-library/jest-dom");
const path = require("path");
const { JSDOM } = require("jsdom");

Expand Down Expand Up @@ -67,16 +68,16 @@ describe("Reading list", () => {
const firstLi = page.window.document.querySelector(
"#reading-list > :first-child"
);
expect(firstLi).toHaveStyle({ backgroundColor: "red" });
expect(firstLi).toHaveClass("notRead");

const secondLi = page.window.document.querySelector(
"#reading-list > :nth-child(2)"
);
expect(secondLi).toHaveStyle({ backgroundColor: "green" });
expect(secondLi).toHaveClass("read");

const thirdLi = page.window.document.querySelector(
"#reading-list > :nth-child(3)"
);
expect(thirdLi).toHaveStyle({ backgroundColor: "green" });
expect(thirdLi).toHaveClass("read");
});
});
9 changes: 9 additions & 0 deletions Sprint-3/reading-list/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,12 @@ body {
max-height: 80px;
}
}
.red {
background-color: red;
}
.read {
background-color: green;
}
.notRead {
background-color: red;
}