-
-
Notifications
You must be signed in to change notification settings - Fork 283
London | ITP-Jan-26 | Mohsen Zamani | Sprint 1 | Coursework #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| function dedupe() {} | ||
| function dedupe(elements) { | ||
| return [...new Set(elements)]; | ||
| } | ||
|
|
||
| module.exports = dedupe; | ||
|
|
||
| console.log(dedupe([4542543, undefined, 4542543, 4542543, null, [], null])); | ||
|
cjyuan marked this conversation as resolved.
Outdated
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,29 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] | |
| // Given an empty array | ||
| // When passed to the dedupe function | ||
| // Then it should return an empty array | ||
| test.todo("given an empty array, it returns an empty array"); | ||
| describe("dedupe", () => { | ||
| it("returns an empty array if passed an empty array", () => | ||
| expect(dedupe([])).toEqual([])); | ||
|
|
||
| // Given an array with no duplicates | ||
| // When passed to the dedupe function | ||
| // Then it should return a copy of the original array | ||
| [ | ||
| { input: [1, 2, 3], expected: [1, 2, 3] }, | ||
| { | ||
| input: [4542543, 65756756, 433254], | ||
| expected: [4542543, 65756756, 433254], | ||
| }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns a copy of original array when passed array with no duplicates ", () => | ||
| expect(dedupe(input)).toEqual(expected)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test should fail if the function returns the original array (instead of a copy of the original array). The current test checks only if both the original array and the returned array contain identical elements. Can you implement this additional check? |
||
| ); | ||
|
|
||
| // Given an array with strings or numbers | ||
| // When passed to the dedupe function | ||
| // Then it should remove the duplicate values, preserving the first occurence of each element | ||
| [ | ||
| { input: [1, 2, 3, "apple", 3, 2, {}], expected: [1, 2, 3, "apple", {}] }, | ||
| { | ||
| input: [4542543, undefined, 4542543, 4542543, null, [], null], | ||
| expected: [4542543, undefined, null, []], | ||
| }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns array wit unique values in their first occurrence index when passed an array with numbers and non-number values ", () => | ||
| expect(dedupe(input)).toEqual(expected)) | ||
| ); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| function findMax(elements) { | ||
| const numberElements = elements.filter((el) => typeof el === "number"); | ||
| if (numberElements.length === 0) return -Infinity; | ||
| return Math.max(...numberElements); | ||
|
cjyuan marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| module.exports = findMax; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,9 @@ | ||
| function sum(elements) { | ||
| if (!Array.isArray(elements)) return 0; | ||
| return elements.reduce((acc, curr) => { | ||
| return typeof curr === "number" ? acc + curr : acc; | ||
| }, 0); | ||
|
cjyuan marked this conversation as resolved.
|
||
| } | ||
|
|
||
| module.exports = sum; | ||
| console.log(sum([])); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,27 +10,82 @@ const sum = require("./sum.js"); | |
|
|
||
| // Acceptance Criteria: | ||
|
|
||
| // Given an empty array | ||
| // When passed to the sum function | ||
| // Then it should return 0 | ||
| test.todo("given an empty array, returns 0") | ||
|
|
||
| // Given an array with just one number | ||
| // When passed to the sum function | ||
| // Then it should return that number | ||
|
|
||
| // Given an array containing negative numbers | ||
| // When passed to the sum function | ||
| // Then it should still return the correct total sum | ||
|
|
||
| // Given an array with decimal/float numbers | ||
| // When passed to the sum function | ||
| // Then it should return the correct total sum | ||
|
|
||
| // Given an array containing non-number values | ||
| // When passed to the sum function | ||
| // Then it should ignore the non-numerical values and return the sum of the numerical elements | ||
|
|
||
| // Given an array with only non-number values | ||
| // When passed to the sum function | ||
| // Then it should return the least surprising value given how it behaves for all other inputs | ||
| describe("sum()", () => { | ||
| it("returns 0 for empty array", () => expect(sum([])).toBe(0)); | ||
|
|
||
| [ | ||
| { input: [4], expected: 4 }, | ||
| { input: [367], expected: 367 }, | ||
| { input: [7958463], expected: 7958463 }, | ||
| ].forEach(({ input, expected }) => { | ||
| it(`returns the sum for arrays with one number`, () => | ||
| expect(sum(input)).toBe(expected)); | ||
| }); | ||
|
|
||
| [ | ||
| { input: [-9], expected: -9 }, | ||
| { input: [-367, -5], expected: -372 }, | ||
| { input: [-7958463, -100, -202, -6453], expected: -7965218 }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns the correct sum for array with only negative values", () => | ||
| expect(sum(input)).toBe(expected)) | ||
| ); | ||
|
|
||
| [ | ||
| { input: [-9, 9], expected: 0 }, | ||
| { input: [-367, -5, 70, 2], expected: -300 }, | ||
| { input: [-7958463, -100, -202, -6453, 153, 45621], expected: -7919444 }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns the correct sum for array containing negative numbers", () => | ||
| expect(sum(input)).toBe(expected)) | ||
| ); | ||
|
|
||
| [ | ||
| { input: [-9, 9, 0.1], expected: 0.1 }, | ||
| { input: [-367, -5, 70, 2, -4.567], expected: -304.567 }, | ||
| { | ||
| input: [-7958463, -100, -202, -6453, 153, 45621, -1.48, 8976.456], | ||
| expected: -7910469.024, | ||
| }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns the correct sum for array containing decimal/float numbers", () => | ||
| expect(sum(input)).toBe(expected)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Decimal numbers in most programming languages (including JS) are internally represented in "floating point number" format. Floating point arithmetic is not exact. For example, the result of So the following could happen expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.805 ); // This fail
expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.8049999999999997 ); // This pass
expect( 0.005 + 0.6 + 1.2 ).toEqual( 1.8049999999999997 ); // This fail
console.log(1.2 + 0.6 + 0.005 == 1.805); // false
console.log(1.2 + 0.6 + 0.005 == 0.005 + 0.6 + 1.2); // falseCan you find a more appropriate way to test a value (that involves decimal number calculations) for equality? Suggestion: Look up
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was interesting. Thank you. |
||
| ); | ||
|
|
||
| [ | ||
| { input: [-9, 9, 0.1, () => {}], expected: 0.1 }, | ||
| { | ||
| input: [-367, -5, "-234", 70, 2, { fruit: "apple" }, -4.567], | ||
| expected: -304.567, | ||
| }, | ||
| { | ||
| input: [ | ||
| -7958463, | ||
| -100, | ||
| "Iran", | ||
| -202, | ||
| -6453, | ||
| "UK", | ||
| 153, | ||
| [], | ||
| 45621, | ||
| "Egypt", | ||
| -1.48, | ||
| 8976.456, | ||
| {}, | ||
| ], | ||
| expected: -7910469.024, | ||
| }, | ||
| ].forEach(({ input, expected }) => | ||
| it("returns the correct sum for array containing decimal/float numbers", () => | ||
| expect(sum(input)).toBe(expected)) | ||
| ); | ||
|
|
||
| [ | ||
| ["not an array", null, undefined, {}, []], | ||
| [("apple", null, undefined)], | ||
| ].forEach((item) => | ||
| it("returns 0 for arrays with only non-number values", () => | ||
| expect(sum(item)).toBe(0)) | ||
| ); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,7 @@ | ||
| // Refactor the implementation of includes to use a for...of loop | ||
|
|
||
| function includes(list, target) { | ||
| for (let index = 0; index < list.length; index++) { | ||
| const element = list[index]; | ||
| if (element === target) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| return list.includes(target) ? true : false; | ||
|
cjyuan marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| module.exports = includes; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| const fs = require("fs"); | ||
|
|
||
| function calculateFrequecy() { | ||
| const text = fs.readFileSync("input.txt", "utf-8"); | ||
| const ChangesInFrequency = text.trim().split(/\r?\n/).map(Number); | ||
|
cjyuan marked this conversation as resolved.
Outdated
|
||
| return ChangesInFrequency.reduce((acc, curr) => acc + curr, 0); | ||
| } | ||
|
cjyuan marked this conversation as resolved.
|
||
Uh oh!
There was an error while loading. Please reload this page.