-
-
Notifications
You must be signed in to change notification settings - Fork 279
London | 26-ITP-Jan | Mohsen Zamani | sprint 2 | coursework #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| function contains() {} | ||
| function contains(obj, property) { | ||
| if (Object.prototype.toString.call(obj) !== "[object Object]") return false; | ||
|
|
||
| return Object.hasOwn(obj, property); | ||
| } | ||
|
|
||
| console.log(contains(undefined, "key1")); | ||
|
|
||
| module.exports = contains; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| if (!Array.isArray(countryCurrencyPairs)) return {}; | ||
| return countryCurrencyPairs.reduce((acc, curr) => { | ||
| acc[curr[0]] = curr[1]; | ||
| return acc; | ||
| }, {}); | ||
| } | ||
|
|
||
| module.exports = createLookup; |
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| function tally() {} | ||
| function tally(list) { | ||
| if (!Array.isArray(list)) throw new Error("Not an array."); | ||
| const obj = Object.create(null); | ||
| return list.reduce((acc, curr) => { | ||
| acc[curr] = (acc[curr] || 0) + 1; | ||
| return acc; | ||
| }, obj); | ||
| } | ||
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| module.exports = tally; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const invert = require("./invert.js"); | ||
|
|
||
| describe("invert", () => { | ||
| it("returns empty object if passed empty object", () => | ||
| expect(invert({})).toEqual({})); | ||
|
|
||
| it("returns inverted object of the passed object", () => { | ||
| expect(invert({ a: 1, b: 2 })).toEqual({ 1: "a", 2: "b" }); | ||
| expect(invert({ a: 1, b: 2, c: 3, d: 4, e: 5 })).toEqual({ | ||
| 1: "a", | ||
| 2: "b", | ||
| 3: "c", | ||
| 4: "d", | ||
| 5: "e", | ||
| }); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,16 @@ | |
|
|
||
| 3. Order the results to find out which word is the most common in the input | ||
| */ | ||
|
|
||
| function countWords(string) { | ||
| const wordArray = string | ||
| .toLowerCase() | ||
| .split(/[.,!? ]+/) | ||
| .filter(Boolean); | ||
| let wordCount = new Map(); | ||
| for (let word of wordArray) { | ||
| wordCount.set(word, (wordCount.get(word) || 0) + 1); | ||
| } | ||
| const sortedWordCount = new Map([...wordCount].sort(([, a], [, b]) => b - a)); | ||
| return sortedWordCount; | ||
|
Comment on lines
+30
to
+43
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you check if your function returns what you expect in the following function calls?
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach to check if
objis an object is not 100% accurate. For example,mapis an object but your approach would not recognise it as an object.This test description in
contains.test.jsis a bit vague because an array is a kind of object in JavaScript:Can you interpret "invalid parameter" as "it is not an object OR it is an array"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the code only need to check the plain objects (excluding Map)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know the intent of the person who wrote the test description. My interpretation is, accept all objects except arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach you were using is not a reliable way to check for pure Object. Without a more specific description of what is expected of such object, let's just practice on "accept any object that is not an array"