-
-
Notifications
You must be signed in to change notification settings - Fork 278
London | 26-ITP-Jan | Mohsen Zamani | sprint 2 | coursework #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| function contains() {} | ||
| function contains(obj, property) { | ||
| try { | ||
| const keys = Object.keys(obj); | ||
| return keys.includes(property); | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } catch (error) { | ||
| throw new Error("The parameter given is not a plain JS object."); | ||
| } | ||
| } | ||
|
|
||
| module.exports = contains; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,16 +20,32 @@ as the object doesn't contains a key of 'c' | |
| // Given an empty object | ||
| // When passed to contains | ||
| // Then it should return false | ||
| test.todo("contains on empty object returns false"); | ||
| test("contains on empty object returns false", () => | ||
| expect(contains({}, "key1")).toEqual(false)); | ||
|
|
||
| // Given an object with properties | ||
| // When passed to contains with an existing property name | ||
| // Then it should return true | ||
| test("contains returns true when object contains the given property", () => | ||
| expect(contains({ key1: "value1", key2: "value2" }, "key1")).toEqual(true)); | ||
|
|
||
| // Given an object with properties | ||
| // When passed to contains with a non-existent property name | ||
| // Then it should return false | ||
| test("contains returns false when object does not contain the given property", () => | ||
| expect(contains({ key1: "value1", key2: "value2" }, "key4")).toEqual(false)); | ||
|
|
||
| // Given invalid parameters like an array | ||
| // When passed to contains | ||
| // Then it should return false or throw an error | ||
| it("contains returns false or throws an error if given parameter is not a valid object", () => { | ||
| expect(contains([], "key1")).toEqual(false); | ||
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expect(contains("key1:value1", "key1")).toEqual(false); | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect(contains(5235, "key1")).toEqual(false); | ||
| expect(() => contains(undefined, "key1")).toThrow( | ||
| "The parameter given is not a plain JS object." | ||
| ); | ||
| expect(() => contains(null, "key1")).toThrow( | ||
| "The parameter given is not a plain JS object." | ||
| ); | ||
|
||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| if (!Array.isArray(countryCurrencyPairs)) return {}; | ||
| return countryCurrencyPairs.reduce((acc, curr) => { | ||
| acc[curr[0]] = curr[1]; | ||
| return acc; | ||
| }, {}); | ||
| } | ||
|
|
||
| module.exports = createLookup; |
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| function tally() {} | ||
| function tally(list) { | ||
| if (!Array.isArray(list)) throw new Error("Not an array."); | ||
| return list.reduce((acc, curr) => { | ||
| acc[curr] = (acc[curr] || 0) + 1; | ||
| return acc; | ||
| }, {}); | ||
| } | ||
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| module.exports = tally; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const invert = require("./invert.js"); | ||
|
|
||
| describe("invert", () => { | ||
| it("returns empty object if passed empty object", () => | ||
| expect(invert({})).toEqual({})); | ||
|
|
||
| it("returns inverted object of the passed object", () => { | ||
| expect(invert({ a: 1, b: 2 })).toEqual({ 1: "a", 2: "b" }); | ||
| expect(invert({ a: 1, b: 2, c: 3, d: 4, e: 5 })).toEqual({ | ||
| 1: "a", | ||
| 2: "b", | ||
| 3: "c", | ||
| 4: "d", | ||
| 5: "e", | ||
| }); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,14 @@ | |
|
|
||
| 3. Order the results to find out which word is the most common in the input | ||
| */ | ||
|
|
||
| function countWords(string) { | ||
| const noPunctuationStr = string.replace(/[.,!?]/g, ""); | ||
| const wordArray = noPunctuationStr.split(" "); | ||
| let wordCount = new Map(); | ||
| for (let word of wordArray) { | ||
| wordCount.set(word, (wordCount.get(word) || 0) + 1); | ||
| } | ||
| const sortedWordCount = [...wordCount.entries()].sort((a, b) => b[1] - a[1]); | ||
| return sortedWordCount; | ||
|
Comment on lines
+30
to
+43
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you check if your function returns what you expect in the following function calls? |
||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.