Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 1 | Coursework/sprint 1#986
Open
Dan2Clouted wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 1 | Coursework/sprint 1#986Dan2Clouted wants to merge 10 commits intoCodeYourFuture:mainfrom
Dan2Clouted wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 17, 2026
Comment on lines
+70
to
+83
| test("given an array containing non-number values, it ignores them and returns the sum of the numerical elements", () => { | ||
| const input = ["hello", "world"]; | ||
| const expectedOutput = 0; | ||
| expect(sum(input)).toBe(expectedOutput); | ||
| }); | ||
|
|
||
| // Given an array with only non-number values | ||
| // When passed to the sum function | ||
| // Then it should return the least surprising value given how it behaves for all other inputs | ||
| test("given an array with only non-number values, it returns the least surprising value", () => { | ||
| const input = ["hello", "world"]; | ||
| const expectedOutput = 0; | ||
| expect(sum(input)).toBe(expectedOutput); | ||
| }); |
Contributor
There was a problem hiding this comment.
I think this exercise also involves "reading data from files". If you are up to the challenge, can you write a script that can read the numbers from a file and then output their sums?
cjyuan
added
Reviewed
Author
|
Thanks for the detailed feedback — really helpful. I’ve gone through all the comments and made the following updates:
|
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 19, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good, but you introduced a bug into one of the files. Can you fix it?
cjyuan
removed
the
Needs Review
Author
|
The bug issues has been resolved. |
Dan2Clouted
added
the
Needs Review
Contributor
|
I can still see the bug. If you run jest test, you should notice some failed tests. |
cjyuan
removed
the
Needs Review
Author
|
I think now it should have been fixed. |
Contributor
|
No new commits pushed to GitHub, and label not yet changed. |
Author
|
Sorry for all this, But i think it should be fixed now. Thank you for your time. |
Dan2Clouted
added
the
Needs Review
Contributor
|
One of the commit fixed the bug but it wasn't pushed to GitHub before. However, a newer commit reintroduced the bug. So the bug remains. |
cjyuan
removed
the
Needs Review
Author
|
It should be fixed now. Thank you for your time and patience. |
cjyuan
removed
the
Reviewed
cjyuan
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all exercises.