Skip to content

Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 | Form-Controls #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abduhasen wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 | Form-Controls #1026

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9be378
create a form and used semantic html, add name input and email input …
Abduhasen Jan 23, 2026
35f7c60
used separat radio name for separat fieldset
Abduhasen Jan 23, 2026
e0033f0
changed the break position
Abduhasen Jan 23, 2026
abae8b4
Add validation patterns for name and email inputs in the form
Abduhasen Jan 29, 2026
78f7ea7
I removed unnecessary spaces in the form-controls
Abduhasen Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 62 additions & 5 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,71 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<p>
<div>
<label for="name">NAME *</label> <!--write customer's name input-->
<input type="text" name="name" id="name" minlength="2" maxlength="20" required>
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you think of a better way to determine what a valid name is

Copy link
Copy Markdown
Author

@Abduhasen Abduhasen Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I researched more and I came up with some update but am not sure it is good enough.

</div>
</p>
<p>
<div>
<label for="email">Email *</label> <!-- customer's email -->
<input type="email" name="email" id="email" required>
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also think of or research for a better way to determine what a valid email is

Copy link
Copy Markdown
Author

@Abduhasen Abduhasen Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did some update but am not sure it is well or not

</div>
</p>
<div>
<fieldset>
<legend> T-shirt colour </legend> <!-- t-shirt colour -->
<ul>
<li>
<label for="red">Red</label><br>
<input type="radio" name="T-shirt colour" id="red">
</li>
<li>
<label for="green">Green</label><br>
<input type="radio" name="T-shirt colour" id="green">
</li>
<li>
<label for="yellow">Yellow</label><br>
<input type="radio" name="T-shirt colour" id="yellow">
</li>
</ul>
</fieldset>
<fieldset>
<legend>T-shirt size</legend> <!-- t-shirt size -->
<ol>
<li>
<label for="XS">XS</label><br>
<input type="radio" name="T-shirt size" id="XS">
</li>
<li>
<label for="S">S</label><br>
<input type="radio" name="T-shirt size" id="S">
</li>
<li>
<label for="M">M</label><br>
<input type="radio" name="T-shirt size" id="M">
</li>
<li>
<label for="L">L</label><br>
<input type="radio" name="T-shirt size" id="L">
</li>
<li>
<label for="XL">XL</label><br>
<input type="radio" name="T-shirt size" id="XL">
</li>
<li>
<label for="XXL">XXL</label><br>
<input type="radio" name="T-shirt size" id="XXL">
</li>
</ol>
</fieldset>
</div>
<button>Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
Abdu Mussa
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
Expand Down
Loading