Conversation
Updated acceptance criteria for webpage structure and layout.
Updated acceptance criteria for webpage layout and articles.
Added recommended practices for code formatting and committing.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| - [ ] All inputs have associated labels. | ||
| - [ ] My Lighthouse Accessibility score is 100. | ||
| - [ ] I require a valid name. I have defined a valid name as a text string of two characters or more. | ||
| - [ ] I require a valid name. I have defined a valid namea as a text string of at least two characters and cannot consist only of spaces. |
There was a problem hiding this comment.
Do we want to dictate this for people? Do we want people to think about this and include it in their PR description?
Right now it reads weirdly to me that we're prompting people "Think about what a valid name is" and then requiring a certain answer (which isn't honestly a great definition, but is an easy one to implement)
|
|
||
| --- | ||
|
|
||
| ### 3. Committing files one by one |
There was a problem hiding this comment.
| ### 3. Committing files one by one | |
| ### 3. Committing files often, in meaningful groups |
There was a problem hiding this comment.
Does anything actually point people at this file? I suspect they are unlikely to happen upon it by chance...
| @@ -0,0 +1,58 @@ | |||
| ## Clean Code and Smart Commits: A Practical Guide | |||
|
|
|||
| ### 1. Formatting code consistently | |||
There was a problem hiding this comment.
Do we want to add any requirements about formatting to the problem requirements? Or just leave this as a suggestion?
2 participants
Changelist