-
-
Notifications
You must be signed in to change notification settings - Fork 465
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 1 | Wireframe #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
66c88bf
7cca5f5
7dbae9f
b70e461
7dc1e66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,56 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Key Web Development Concepts</h1> | ||
| <p> | ||
| Definitions of README files, Wireframes, and Git branches. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="image_readme.webp" alt="A picture about the necessity of the readme file" /> | ||
| <h2>What is a README file?</h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| A README file is a document included in a project that explains what the project is about, how to set it up, and | ||
| how to use it. It helps other developers and users understand your work quickly. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <a | ||
| href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read | ||
| more</a> | ||
| </article> | ||
| <article> | ||
| <img src="image_wireframe.avif" alt="Wireframe sketch example" /> | ||
| <h2>What is a Wireframe?</h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| A wireframe is a simple visual guide that represents the structure of a webpage or app. It shows where elements like buttons, text, and images will be placed and how users will interact with them. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| <a href="https://www.productplan.com/glossary/wireframe/">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="image_branch.webp" alt="Git branches diagram" /> | ||
| <h2>What is a Branch in Git?</h2> | ||
| <p> | ||
| A branch in Git is a separate line of development in a project. It allows you to work on new features or fixes without affecting the main code. Once ready, the changes can be merged back into the main branch. | ||
| </p> | ||
| <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <ul> | ||
| <li><a href="mailto:elisabeth.matulian@example.com">Email</a></li> | ||
| <li><a href="https://codeyourfuture.io">Website</a></li> | ||
| <li><p>© 2026 Elisabeth Matulian</p></li> | ||
| </ul> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
This file was deleted.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * styled-components and SSR does not work well with @font-face. They will | ||
| * introduce a reloading of font-face every time it is used and case a | ||
| * distracting flickering effect. To solve this we sipmly use a standard | ||
| * css file where we define our @font-face's and import it directly into | ||
| * the index.html (in gatsby this is in src/html.js -- if it doesn't exist | ||
| * it means you are using the default one that you can copy from | ||
| * .cache/default-html.js) | ||
| * | ||
| * ref: https://font-face-import.netlify.app/ | ||
| * ref: https://styled-components.com/docs/faqs#how-do-i-fix-flickering-text-after-server-side-rendering | ||
| * */ | ||
|
|
||
| /** | ||
| * font-face | ||
| */ | ||
|
|
||
| :root { | ||
| /* Font */ | ||
| --font-default: "proxima-nova", Helvetica, Arial, sans-serif; | ||
| --font-highlight: "Gilroy", "Helvetica Neue", Helvetica, Roboto, Arial, sans-serif; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Gilroy; | ||
| font-display: swap; | ||
| font-style: normal; | ||
| font-weight: normal; | ||
| src: | ||
| url('/fonts/gilroy-regular-webfont.woff2') format('woff2'), | ||
| url('/fonts/gilroy-regular-webfont.woff') format('woff'); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Gilroy; | ||
| font-display: swap; | ||
| font-style: normal; | ||
| font-weight: 500; | ||
| src: | ||
| url('/fonts/gilroy-medium-webfont.woff2') format('woff2'), | ||
| url('/fonts/gilroy-medium-webfont.woff') format('woff'); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Gilroy; | ||
| font-display: swap; | ||
| font-style: normal; | ||
| font-weight: bold; | ||
| src: | ||
| url('/fonts/gilroy-bold-webfont.woff2') format('woff2'), | ||
| url('/fonts/gilroy-bold-webfont.woff') format('woff'); | ||
| } | ||
|
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your footer is looking better now. However, I see a few issues that should be fixed.
<li>elements, the default will show a bullet point. Can you find a way to ensure that those bullet points are not displayed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your helpful feedback. I’ve made changes but I'm not sure if I correctly understand the way the footer should look.
I’d really appreciate it if you could take another look and let me know if everything looks good now.
Thanks again for your guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elisabeth-Matulian - I had a look at your footer and I think there are a few opportunities to improve it.
I took a video recording for you to see what I mean. I also added an orange background colour to it. You can see that your footer isn't spanning the entire width of the screen.
Can you make changes to:
1 - Add a background color so the user can always see your footer?
2 - Ensure that the footer takes up the entire width of the page?
Screen.Recording.2026-01-20.at.3.07.46.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for taking the time to review my work and for the detailed feedback.
I’ve now updated the footer to add a background colour and ensured it spans the full width of the page.
When you have a moment, could you please have another look and let me know if everything looks correct now?
Thanks again for your help.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elisabeth-Matulian I'm glad you found my comments useful!
I reviewed the footer and see it's now visible ✅ and it's full width ✅. I ran an accessibility report against your page and see a small issue with the contrast ratio of the footer. Can you take a look?
Also, wanted to point out that the 'Read more' buttons on the wireframe have a complete border around them and yours only have an underline.☺️
https://github.com/CodeYourFuture/Module-Onboarding/tree/main/Wireframe
At this point, I'm not going to ask you change that -> but wanted to highlight to ensure in the future that you try to follow the wireframe as closely as possible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing my updates. I’m glad the previous changes improved the footer.
I’ve noted the accessibility contrast issue and adjusted it. When you have a moment, could you please take another look at my full submission?