London | ITP-Jan-2016 | Ping Wang | Sprint 1 | Wireframe#979
Open
pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
London | ITP-Jan-2016 | Ping Wang | Sprint 1 | Wireframe#979pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
pathywang
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
pathywang
changed the title
This comment has been minimized.
This comment has been minimized.
pathywang
changed the title
This comment has been minimized.
This comment has been minimized.
pathywang
changed the title
pathywang
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Jan 23, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
In your PR Description
1
Can you edit the Markdown syntax of the checkboxes to make them looks like this
- I have tested my changes
instead of like this:
[x] I have tested my changes
2
It would be better to keep the "Changelist" header.
3
There are some typos and grammar mistakes in the description.
Suggestion: Use AI to check for typos, grammar mistakes, and even suggest improvements, and learn from the process.
In index.html
The HTML code looks good.
However, the text content has some typos.
Suggestion: Share your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency.
It can often help us catch errors, improve consistency, and reinforce best practices.
| </article> | ||
| </main> | ||
| <footer> | ||
| <p>ITP-JAN-25 | Ping Wang | Module: Onboarding | wifeframe</p> |
Contributor
There was a problem hiding this comment.
Shouldn't it be 26 and Wireframe?
cjyuan
added
Reviewed
pathywang
added
Needs Review
Contributor
|
There are still some typos or incorrectly spelled words in the PR description and in |
cjyuan
added
Reviewed
pathywang
added
Needs Review
Contributor
|
Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I created a new branch because my previous one became a bit messy. I checked the project using Lighthouse; Best Practices scored 93, and all other categories scored 100, which I hope is acceptable. I also shared my code with an AI tool to help identify and correct some typos.