reviewed errors fixed

Author: MehrozMunir

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,31 +23,39 @@
 
 function getCardValue(card) {
   // Handling invalid cards
-  try{
-  const rank = card.slice(0,-1); //rank of the card is everything except the last character of card string
-  const suit = card.slice(-1); // suit is the last character of the card string
-  if((card.length != 2 && card.length !=3) || !isValidCard(rank, suit)){
-    throw new Error("Invalid card");
-  }
-  if(rank === "J" || rank === "Q" || rank == "K")
-    return 10
-  else if(rank == "A")
-    return 11;
-  else
-    return Number(rank);
-  }
-  catch(e){
+  try {
+    const rank = card.slice(0, -1); //rank of the card is everything except the last character of card string
+    const suit = card.slice(-1); // suit is the last character of the card string
+    if (!isValidCard(rank, suit)) {
+      throw new Error("Invalid card");
+    }
+    if (rank === "J" || rank === "Q" || rank == "K") return 10;
+    else if (rank == "A") return 11;
+    else return Number(rank);
+  } catch (e) {
     return e.message;
   }
 }
 
-function isValidCard(rank,suit){
-  const ranks = ["A", "2", "3", "4", "5", "6", "7", "8", "9", "10", "J", "Q", "K"];
+function isValidCard(rank, suit) {
+  const ranks = [
+    "A",
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+    "10",
+    "J",
+    "Q",
+    "K",
+  ];
   const suits = ["♠", "♥", "♦", "♣"];
-  if(ranks.includes(rank) && suits.includes(suit))
-    return true;
-  else
-    return false;
+  if (ranks.includes(rank) && suits.includes(suit)) return true;
+  else return false;
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -65,7 +73,6 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
-
 assertEquals(getCardValue("10♠"), 10);
 assertEquals(getCardValue("Q♠"), 10);
 assertEquals(getCardValue("A♣"), 11);
@@ -76,4 +83,4 @@ assertEquals(getCardValue("Invalid"), "Invalid card");
 assertEquals(getCardValue("1Q"), "Invalid card");
 assertEquals(getCardValue("-10♦"), "Invalid card");
 assertEquals(getCardValue("♦K"), "Invalid card");
-assertEquals(getCardValue("Q♦♦"), "Invalid card");
+assertEquals(getCardValue("Q♦♦"), "Invalid card");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,18 +4,40 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
-// Special case: numerator is zero
+//Case 1: denominator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(-1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+  expect(isProperFraction(3848473, 0)).toEqual(false);
+});
+
+//Case 2: numerator is 0 but denominator is not 0
+test(`should return true when numerator is zero but denominator is not 0`, () => {
   expect(isProperFraction(0, 1)).toEqual(true);
-  expect(isProperFraction(0, -1)).toEqual(true);
+  expect(isProperFraction(0, -100)).toEqual(true);
+  expect(isProperFraction(0, 1000)).toEqual(true);
+});
+
+//Case 3: Absolute values of numerator and denominator are equal
+test(`should return false when numerator and denominator have equal absolute values`, () => {
   expect(isProperFraction(1, 1)).toEqual(false);
+  expect(isProperFraction(-181, 181)).toEqual(false);
+  expect(isProperFraction(839984, 839984)).toEqual(false);
+  expect(isProperFraction(-1211, -1211)).toEqual(false);
+});
+
+//Case 4: Absolute value of numerator is less than absolute value of denominator
+test(`should return true when absolute numerator is less than absolute denominator`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
   expect(isProperFraction(1, -2)).toEqual(true);
-  expect(isProperFraction(-6, -2)).toEqual(false);
   expect(isProperFraction(-2, -6)).toEqual(true);
-  expect(isProperFraction(-200, -0)).toEqual(false);
   expect(isProperFraction(-0, -1000)).toEqual(true);
+});
+
+//Case 5: Absolute value of numerator is greater than absolute value of denominator
+test(`should return false when absolute numerator is greater than absolute denominator`, () => {
+  expect(isProperFraction(-6, -2)).toEqual(false);
   expect(isProperFraction(5, 3)).toEqual(false);
   expect(isProperFraction(-25, 3)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -10,7 +10,7 @@ test(`Should return 11 when given an ace card`, () => {
 });
 
 // Case 2: Number Cards (2-10)
-test(`Should return number when given a number`, () => {
+test(`Should return number when given a number card`, () => {
   expect(getCardValue("2♠")).toEqual(2);
   expect(getCardValue("10♠")).toEqual(10);
   expect(getCardValue("5♠")).toEqual(5);