implement recommendation from PR

Author: Abayie

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -8,34 +8,31 @@ const getOrdinalNumber = require("./get-ordinal-number");
 // When the number is 1,
 // Then the function should return "1st"
 
-test("should return '1st' for 1", () => {
+test("append 'st' to numbers ending in 1, except those ending in 11", () => {
   expect(getOrdinalNumber(1)).toEqual("1st");
+  expect(getOrdinalNumber(101)).toEqual("101st");
 });
 
-//identify ordinal for 2
-test("should return '2nd' for 2", () => {
+//identify ordinal for nd
+test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
   expect(getOrdinalNumber(2)).toEqual("2nd");
+  expect(getOrdinalNumber(132)).toEqual("132nd");
 });
 
-//identify ordinal for 3
-test("should return '3rd' for 3", () => {
+//identify ordinal for rd
+test("append 'rd' to numbers ending in 3, except those ending in 13", () => {
   expect(getOrdinalNumber(3)).toEqual("3rd");
-});
-
-//identify ordinal for 4
-test("should return '4th' for 4", () => {
-  expect(getOrdinalNumber(4)).toEqual("4th");
+  expect(getOrdinalNumber(23)).toEqual("23rd");
 });
 
 //Special English Rule... 12, 13, 14 ending in "th"
-test("should return '11th' for 11", () => {
+test("append 'th' to numbers that end in 11, 12, or 13", () => {
   expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(113)).toEqual("113th");
 });
 
-test("should return '12th' for 12", () => {
-  expect(getOrdinalNumber(12)).toEqual("12th");
-});
-
-test("should return '13th' for 13", () => {
-  expect(getOrdinalNumber(13)).toEqual("13th");
+//All other numbers => th
+test("append 'th' to all other numbers", () => {
+  expect(getOrdinalNumber(4)).toEqual("4th");
+  expect(getOrdinalNumber(100)).toEqual("100th");
 });

Sprint-3/2-practice-tdd/repeat.js

@@ -1,36 +1,14 @@
-function repeat() {
-  if (arguments[1] < 0) throw new Error("Count must be non-negative");
-  return arguments[0].repeat(arguments[1]);
+function repeat(str, count) {
+  if (count < 0) {
+    throw new Error("Count must be non-negative");
+  }
+
+  let result = "";
+  for (let i = 0; i < count; i++) {
+    result += str;
+  }
+  return result;
 }
-//other implementation
-// function repeat(str, count) {
-//   if (count < 0) {
-//     throw new Error("Count must be non-negative");
-//   }
-
-//   let result = "";
-//   for (let i = 0; i < count; i++) {
-//     result += str;
-//   }
-//   return result;
-// }
-
-// module.exports = repeat;
-
-// function repeat() {
-//   const str = arguments[0];
-//   const count = arguments[1];
-
-//   if (count < 0) {
-//     throw new Error("Count must be non-negative");
-//   }
-
-//   let output = "";
-//   for (let i = 0; i < count; i++) {
-//     output += str;
-//   }
-
-//   return output;
-// }
 
 module.exports = repeat;
+

Sprint-3/2-practice-tdd/repeat.test.js

@@ -2,19 +2,28 @@
 
 const repeat = require("./repeat");
 
-test("should repeat the string count times", () => {
-  expect(repeat("hello", 3)).toEqual("hellohellohello");
-});
-
-test("should return the original string when count is 1", () => {
-  expect(repeat("hello", 1)).toEqual("hello");
+// case: handle Count of 1:
+// When count = 1, return the original string unchanged
+test("should return original string when count is 1", () => {
+  const str = "hello";
+  const count = 1;
+  const repeatedStr = repeat(str, count);
+  expect(repeatedStr).toEqual("hello");
 });
 
+// case: Handle Count of 0:
+// When count = 0, return empty string
 test("should return an empty string when count is 0", () => {
-  expect(repeat("hello", 0)).toEqual("");
+  const str = "world";
+  const count = 0;
+  const repeatedStr = repeat(str, count);
+  expect(repeatedStr).toEqual("");
 });
 
+// case: Negative Count:
+// When count < 0, throw an error
 test("should throw an error when count is negative", () => {
-  expect(() => repeat("hello", -2)).toThrow("Count must be non-negative");
+  const str = "test";
+  const count = -3;
+  expect(() => repeat(str, count)).toThrow("Count must be non-negative");
 });
-