added implementation for invalid cards and removed direct calls from get-value-card to test file

Author: fayaz551

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,15 +22,25 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  // TODO: Implement this function
-  const rank = card.slice(0, -1);
-  const suit = card.slice(-1);
-  if (rank === "A") {
-    return 11;
+  const validRanks = ["A","2","3","4","5","6","7","8","9","10","J","Q","K"];
+  const validSuits = ["♠","♥","♦","♣"];
+
+  // Check type
+  if (typeof card !== "string") {
+    throw new Error("Invalid card string");
   }
-  if (rank === "J" || rank === "Q" || rank === "K") {
-    return 10;
+
+  const suit = card.slice(-1);
+  const rank = card.slice(0, -1);
+
+  // Validate rank and suit
+  if (!validRanks.includes(rank) || !validSuits.includes(suit)) {
+    throw new Error("Invalid card string");
   }
+
+  // Compute value
+  if (rank === "A") return 11;
+  if (["J","Q","K"].includes(rank)) return 10;
   return parseInt(rank);
 }
 
@@ -48,7 +58,7 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9♠"), 9);
+/* assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
 try {
@@ -68,3 +78,4 @@ try {
 try {  getCardValue("9X"); // Invalid suit
   console.error("Error was not thrown for invalid suit");
 } catch (e) {}
+*/

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -23,13 +23,17 @@ test(`Should return 10 for face cards`, () => {
 });
 //   Invalid Cards
 test(`Should throw an error for invalid cards`, () => {
-  expect(() => getCardValue("invalid")).toThrow();
-  expect(() => getCardValue("A")).toThrow(); // Missing suit
-  expect(() => getCardValue("11♠")).toThrow(); // Invalid rank
-  expect(() => getCardValue("9X")).toThrow(); // Invalid suit
+  expect(() => getCardValue("invalid")).toThrow("Invalid card string");
+  expect(() => getCardValue("A")).toThrow("Invalid card string"); // Missing suit
+  expect(() => getCardValue("11♠")).toThrow("Invalid card string"); // Invalid rank
+  expect(() => getCardValue("9X")).toThrow("Invalid card string"); // Invalid suit
 });
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
 
+
+
+
+