Made changes based on comments received.

Author: A-Moiz

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,13 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if (denominator === 0) {
-    return false;
-  } else if (Math.abs(numerator) < Math.abs(denominator)) {
-    return true;
-  } else {
-    return false;
-  }
+  return Math.abs(numerator) < Math.abs(denominator) ? true : false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,16 +22,23 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  const rank = card.slice(0, card.length - 1);
-  if (rank === "A") {
-    return 11;
-  } else if (Number(rank) >= 2 && Number(rank) < 10) {
-    return Number(rank);
-  } else if (rank === "10" || rank === "J" || rank === "Q" || rank === "K") {
-    return 10;
-  } else {
-    return "Invalid card rank";
+  const rank = card.slice(0, -1);
+  const lastChar = card.slice(-1);
+  const validSuits = ["♠", "♥", "♦", "♣"];
+
+  if (!validSuits.includes(lastChar)) {
+    throw new Error("Invalid card suit");
+  }
+
+  if (rank === "A") return 11;
+  if (rank === "10" || rank === "J" || rank === "Q" || rank === "K") return 10;
+
+  const rankNum = Number(rank);
+  if (!Number.isNaN(rankNum) && rankNum >= 2 && rankNum < 10) {
+    return rankNum;
   }
+
+  throw new Error("Invalid card rank");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -76,5 +83,8 @@ assertEquals(aceofClubs, 11);
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
-const invalidCard = getCardValue("1♠");
-assertEquals(invalidCard, "Invalid card rank");
+try {
+  getCardValue("1♠");
+} catch (error) {
+  assertEquals(error.message, "Invalid card rank");
+}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -24,3 +24,19 @@ test(`should return true for numerator zero and positive denominator`, () => {
 test(`should return false for denominator zero`, () => {
   expect(isProperFraction(5, 0)).toEqual(false);
 });
+
+test(`should return false for negative denominator`, () => {
+  expect(isProperFraction(5, -2)).toEqual(false);
+});
+
+test(`should return false for negative numerator`, () => {
+  expect(isProperFraction(-5, 2)).toEqual(false);
+});
+
+test(`should return false for negative numerator`, () => {
+  expect(isProperFraction(-5, 2)).toEqual(false);
+});
+
+test(`should return true for negative numerator and negative denominator where numerator is smaller.`, () => {
+  expect(isProperFraction(-1, -2)).toEqual(true);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -29,10 +29,17 @@ test(`Should return 10 for face cards`, () => {
 });
 
 // Case 4: Invalid Cards
-test(`Should return Invalid card rank for invalid cards`, () => {
-  expect(getCardValue("1♠")).toEqual("Invalid card rank");
-  expect(getCardValue("11♥")).toEqual("Invalid card rank");
-  expect(getCardValue("Z♦")).toEqual("Invalid card rank");
+test(`Should throw an error for Invalid card rank for invalid cards`, () => {
+  expect(() => getCardValue("1♠")).toThrow("Invalid card rank");
+  expect(() => getCardValue("11♥")).toThrow("Invalid card rank");
+  expect(() => getCardValue("Z♦")).toThrow("Invalid card rank");
+});
+
+// Case 5: Invalid suit character
+test(`Should throw an error for invalid suit character`, () => {
+  expect(() => getCardValue("1*")).toThrow("Invalid card suit");
+  expect(() => getCardValue("11-")).toThrow("Invalid card suit");
+  expect(() => getCardValue("Z/")).toThrow("Invalid card suit");
 });
 
 // To learn how to test whether a function throws an error as expected in Jest,