Skip to content

Commit 8234f45

Browse files
committed
updated 1-get-angle-type-test.js and get-angle-type.js fixed invalid angle value and formatted code using prettier
1 parent 5e44659 commit 8234f45

2 files changed

Lines changed: 24 additions & 26 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,29 @@
1414
// After you have implemented the function, write tests to cover all the cases, and
1515
// execute the code to ensure all tests pass.
1616

17-
function getAngleType(angle){
18-
if(angle >0 && angle <90){
17+
function getAngleType(angle) {
18+
if (angle > 0 && angle < 90) {
1919
return "Acute angle";
2020
}
21-
if(angle === 90){
21+
if (angle === 90) {
2222
return "Right angle";
2323
}
2424

25-
if(angle >90 && angle <180){
25+
if (angle > 90 && angle < 180) {
2626
return "Obtuse angle";
2727
}
2828

29-
if(angle === 180){
29+
if (angle === 180) {
3030
return "Straight angle";
3131
}
3232

33-
if(angle >180 && angle <360){
33+
if (angle > 180 && angle < 360) {
3434
return "Reflex angle";
3535
}
36-
return "Invalid angle found"
36+
return "Invalid angle";
3737
}
3838

39-
40-
// TODO: Implement this function
41-
39+
// TODO: Implement this function
4240

4341
// The line below allows us to load the getAngleType function into tests in other files.
4442
// This will be useful in the "rewrite tests with jest" step.
@@ -71,14 +69,14 @@ const reflex = getAngleType(275);
7169
assertEquals(reflex, "Reflex angle");
7270
// test invalid cases
7371

74-
const invalidAngleCase1 = getAngleType (0);
75-
assertEquals(invalidAngleCase1, "Invalid angle found");
72+
const invalidAngleCase1 = getAngleType(0);
73+
assertEquals(invalidAngleCase1, "Invalid angle");
7674

77-
const invalidAngleCase2 = getAngleType (-15);
78-
assertEquals(invalidAngleCase2, "Invalid angle found");
75+
const invalidAngleCase2 = getAngleType(-15);
76+
assertEquals(invalidAngleCase2, "Invalid angle");
7977

80-
const invalidAngleCase3 = getAngleType (360);
81-
assertEquals(invalidAngleCase3, "Invalid angle found");
78+
const invalidAngleCase3 = getAngleType(360);
79+
assertEquals(invalidAngleCase3, "Invalid angle");
8280

83-
const invalidAngleCase4 = getAngleType (400);
84-
assertEquals(invalidAngleCase4, "Invalid angle found");
81+
const invalidAngleCase4 = getAngleType(400);
82+
assertEquals(invalidAngleCase4, "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ const getAngleType = require("../implement/1-get-angle-type");
99
// Case 1: Acute angles
1010
// When angle is greater that 0 and less than 90
1111
test(`should return "Acute angle" when (angle >0 angle < 90)`, () => {
12-
expect(getAngleType(1)).toEqual("Acute angle");
13-
expect(getAngleType(45)).toEqual("Acute angle");
14-
expect(getAngleType(89)).toEqual("Acute angle");
12+
expect(getAngleType(1)).toEqual("Acute angle");
13+
expect(getAngleType(45)).toEqual("Acute angle");
14+
expect(getAngleType(89)).toEqual("Acute angle");
1515
});
1616

1717
// Case 2: Right angles
@@ -44,9 +44,9 @@ test(`should return "Reflex angle" when (angle >180 & angle <360)`, () => {
4444

4545
// Case 6: Invalid angles
4646
// When angle is equal to or less than 0 and is equal to or greater than 360
47-
test(`should return "Invalid angle found" when (angle <= 0 or angle >= 360)`, () => {
48-
expect(getAngleType(0)).toEqual("Invalid angle found");
49-
expect(getAngleType(-1)).toEqual("Invalid angle found");
50-
expect(getAngleType(360)).toEqual("Invalid angle found");
51-
expect(getAngleType(520)).toEqual("Invalid angle found");
47+
test(`should return "Invalid angle" when (angle <= 0 or angle >= 360)`, () => {
48+
expect(getAngleType(0)).toEqual("Invalid angle");
49+
expect(getAngleType(-1)).toEqual("Invalid angle");
50+
expect(getAngleType(360)).toEqual("Invalid angle");
51+
expect(getAngleType(520)).toEqual("Invalid angle");
5252
});

0 commit comments

Comments
 (0)