Done the Implement and rewrite

Author: Seti-Jemal

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -14,35 +14,33 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-  function getAngleType(angle) {
-  if (angle <= 0 || angle >= 360)
-    }
+  if (angle <= 0 || angle >= 360) {
+    return "Invalid angle";
+  }
 
   if (angle < 90) {
-    return "acute angle";
+    return "Acute angle";
+  }
+  if (angle === 90) {
+    return "Right angle";
+  }
+  if (angle < 180) {
+    return "Obtuse angle";
+  }
+  if (angle === 180) {
+    return "Straight angle";
+  }
+  if (angle < 360) {
+    return "Reflex angle";
   }
- if (angle === 90) {
-   return "right angle";
- }
- if (angle < 180){
-   return "obtuse angle";
- }
-   if (angle === 180){
-     return "straight angle";
-   }
-if (angle < 360){
-  return "reflex angle";
 }
 module.exports = getAngleType;
 
-
-  // TODO: Implement this function
-
+// TODO: Implement this function
 
 // The line below allows us to load the getAngleType function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 
-
 // This helper function is written to make our assertions easier to read.
 // If the actual output matches the target output, the test will pass
 function assertEquals(actualOutput, targetOutput) {
@@ -57,7 +55,7 @@ function assertEquals(actualOutput, targetOutput) {
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
 
-   // Test
+// Test
 assertEquals(getAngleType(45), "Acute angle");
 assertEquals(getAngleType(90), "Right angle");
 assertEquals(getAngleType(120), "Obtuse angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,23 +11,37 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  return numerator < denominator;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
-module.exports = isProperFraction;
 
-// Here's our helper again
+// Here's our hel per again
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
     `Expected ${actualOutput} to equal ${targetOutput}`
   );
 }
+module.exports = isProperFraction;
 
 // TODO: Write tests to cover all cases.
 // What combinations of numerators and denominators should you test?
 
-// Example: 1/2 is a proper fraction
-assertEquals(isProperFraction(1, 2), true);
+//Test
+// Proper fraction
+assertEquals(isProperFraction(3, 5), true);
+assertEquals(isProperFraction(4, 8), true);
+assertEquals(isProperFraction(-1, 2), true);
+assertEquals(isProperFraction(-1, -2), true);
+assertEquals(isProperFraction(1, -2), true);
+
+//Not
+assertEquals(isProperFraction(9, 7), false);
+assertEquals(isProperFraction(13, 11), false);
+assertEquals(isProperFraction(19, 10), false);
+assertEquals(isProperFraction(17, 3), false);
+
+//Edge case
+assertEquals(isProperFraction(0, 5), true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,12 +22,27 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  // TODO: Implement this function
+  const rank = card.slice(0, -1);
+  const suit = card.slice(-1);
+
+const vaildSuits = ["♠", "♥", "♦", "♣"];
+  const vailRanks = ["A","2","3","4","5","6","7","8","9","10","J","Q","k"];
+
+  if (!vaildSuits.includes(suit) || !validRanks.inculdes(rank)){
+    throw new Error("Invaild card");
+  }
+  if (rank === "A") return 11;
+  if (rank === "J" || rank === "Q" || rank === "K") return 10;
+
+  return Number(rank);
 }
 
+module.exports = getCardValue;
+
+
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
-module.exports = getCardValue;
+
 
 // Helper functions to make our assertions easier to read.
 function assertEquals(actualOutput, targetOutput) {
@@ -40,13 +55,18 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
+//Test
+assertEquals(getCardvalue("A♠"), 11);
+assertEquals(getCardEqual("J♣), 10);
+assertEquals(getCardequal("10♥"), 10);
 
 // Handling invalid cards
 try {
   getCardValue("invalid");
+  
 
   // This line will not be reached if an error is thrown as expected
   console.error("Error was not thrown for invalid card");
 } catch (e) {}
 
-// What other invalid card cases can you think of?
+// What other invalid card cases can you think of?