Apply changes commented by the reviewer

Author: mohsenzamanist

Sprint-3/4-stretch/card-validator.js

@@ -6,19 +6,11 @@ function creditCardValidator(cardNum) {
   if (cardNumArray.length !== 16) return false;
 
   // checks if all digits are numbers
-  if (
-    !cardNumArray.every(
-      (num) => num.charCodeAt(0) >= 48 && num.charCodeAt(0) <= 57
-    )
-  )
-    return false;
+  if (!cardNumArray.every((num) => num >= 0 && num <= 9)) return false;
 
   // Checks if there are at least two different digits
-  const count = cardNumArray.reduce((acc, curr) => {
-    acc[curr] = acc[curr] ? acc[curr] + 1 : 1;
-    return acc;
-  }, {});
-  if (Object.keys(count).length < 2) return false;
+  const count = new Set(cardNumArray);
+  if (count.size < 2) return false;
 
   // Checks if the sum of all digits is greater than 16
   const sumOfDigits = cardNumArray.reduce((acc, curr) => acc + Number(curr), 0);
@@ -28,3 +20,4 @@ function creditCardValidator(cardNum) {
   if (cardNumArray[cardNumArray.length - 1] % 2 !== 0) return false;
   return true;
 }
+console.log(creditCardValidator("1111111111111111"));

Sprint-3/4-stretch/password-validator.js

@@ -1,5 +1,4 @@
-const previousPasswords = ["5B43n21"];
-function passwordValidator(password) {
+function passwordValidator(password, previousPasswords = []) {
   if (password.length < 5) return false;
   if (previousPasswords.includes(password)) return false;
   previousPasswords.push(password);

Sprint-3/4-stretch/password-validator.test.js

@@ -15,52 +15,52 @@ To be valid, a password must:
 You must breakdown this problem in order to solve it. Find one test case first and get that working
 */
 const isValidPassword = require("./password-validator");
-test("password has at least 5 characters", () => {
+test("should return false if password has fewer than 5 characters", () => {
   // Arrange
-  const password = "A1b2";
+  const password = "A1b&";
   // Act
   const result = isValidPassword(password);
   // Assert
   expect(result).toEqual(false);
 });
 
-test("password is not previously used", () => {
+test("should return false if password was previously used", () => {
   // Arrange
-  const password = "5B43n21";
+  const password = "5B43n21!";
   // Act
-  const result = isValidPassword(password);
+  const result = isValidPassword(password, "5B43n21!");
   // Assert
   expect(result).toEqual(false);
 });
 
-test("password contains at least one uppercase English letter", () => {
+test("should return false if password does not contain an uppercase English letter", () => {
   // Arrange
-  const password = "1a2345";
+  const password = "1a2345&";
   // Act
   const result = isValidPassword(password);
   // Assert
   expect(result).toEqual(false);
 });
 
-test("password contains at least one uppercase English letter", () => {
+test("should return false if password does not contain an lowercase English letter", () => {
   // Arrange
-  const password = "1B2345";
+  const password = "1B2345%";
   // Act
   const result = isValidPassword(password);
   // Assert
   expect(result).toEqual(false);
 });
 
-test("password contains at least one number(0-9)", () => {
+test("should return false if password has no numbers(0-9)", () => {
   // Arrange
-  const password = "sdkerjJNGk";
+  const password = "se!rjJN%Gk";
   // Act
   const result = isValidPassword(password);
   // Assert
   expect(result).toEqual(false);
 });
 
-test('password contains at least one of "!", "#", "$", "%", ".", "*", "&"', () => {
+test('should return false if password has no special characters including "!", "#", "$", "%", ".", "*", "&"', () => {
   // Arrange
   const password = "sdkerjJNG23k";
   // Act
@@ -69,11 +69,11 @@ test('password contains at least one of "!", "#", "$", "%", ".", "*", "&"', () =
   expect(result).toEqual(false);
 });
 
-test("password meets all the condition for a valid password and passwordValidator returns true", () => {
+test("should return true if password meets all validation rules", () => {
   // Arrange
-  const password = "sdkerjJNG23k&";
+  const password = "sdkerj!JNG23k&";
   // Act
-  const result = isValidPassword(password);
+  const result = isValidPassword(password, ["se!rjJN%G6k", "1B2h345%a"]);
   // Assert
   expect(result).toEqual(true);
 });