Skip to content

London | 26-ITP-January | Damian Dunkley | Sprint 3 | Refactoring dead-code #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianDL wants to merge 9 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-January | Damian Dunkley | Sprint 3 | Refactoring dead-code #1057

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2cd9c14
updates for sprint 3 2-practice-tdd, Count and repeat
DamianDL Feb 25, 2026
2727638
updates for sprint 3 2-practice-tdd, get ordinal no.s
DamianDL Feb 25, 2026
f2e5eba
updates for sprint 3 3-dead-code exercise 1
DamianDL Feb 25, 2026
dc0987a
updates for sprint 3 3-dead-code exercise 2
DamianDL Feb 25, 2026
c1a3f24
Merge branch 'CodeYourFuture:main' into coursework/sprint-3-dead-code
DamianDL Feb 25, 2026
a893b09
removing practice-tdd from branch
DamianDL Feb 25, 2026
d257d62
update to exercise-1 to remove dead code not just comment it out
DamianDL Mar 2, 2026
b3b6efd
update to exercise-2 to remove dead code not just comment it out
DamianDL Mar 2, 2026
9a73d7c
refactoring exercise 1 to keep test in local by including in a function
DamianDL Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out and removing are not the same thing; knowing that, can you tidy these files up?

Copy link
Copy Markdown
Author

@DamianDL DamianDL Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hkavalikas, thanks for reviewing. Exercises updated with code deleted not just commented out. Thanks Damian

Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
//let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
//const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
// console.log(greetingStr);
}

testName = "Aman";
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will either result in a variable in the global scope or throw an error. Can you find a way to change it?

Copy link
Copy Markdown
Author

@DamianDL DamianDL Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hkavalikas, exercise 1 updated with the test moved to a function. Thanks Damian

Expand Down
8 changes: 4 additions & 4 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note re; comment vs deletion

Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Copy link
Copy Markdown
Author

@DamianDL DamianDL Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hkavalikas-Thanks for the feedback, However I don't understand it? All comments removed and only code remains in exercise 2. Please could you explain what I need to do to correct? Thanks

Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah apologies @DamianDL , I meant it looks great with the ✅ and that the task was done. The PR already has the Complete status :)

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
//const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}
//function logPets(petsArr) {
//petsArr.forEach((pet) => console.log(pet));
//}

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand Down
Loading