-
-
Notifications
You must be signed in to change notification settings - Fork 337
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 10 commits
0277b9d
f122d5d
1da9615
e4845c4
e56c42c
7f2b357
23a26c6
c456e28
babb7ac
9e13ea1
c76e43f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| if (findCharacter == "") return 0; | ||
|
|
||
| const string = stringOfCharacters.toLowerCase(); | ||
| const char = findCharacter.toLowerCase(); | ||
|
|
||
| return string.split(char).length - 1; | ||
| } | ||
|
|
||
| module.exports = countChar; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,25 @@ test("should count multiple occurrences of a character", () => { | |
| // And a character `char` that does not exist within `str`. | ||
| // When the function is called with these inputs, | ||
| // Then it should return 0, indicating that no occurrences of `char` were found. | ||
| test(`should return 0 for no occurances of 'char' in 'str'`, () => { | ||
| const str = "code your future"; | ||
| const char = "x"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }) | ||
|
|
||
| test(`in case sensitive case, should also return the number of character in the string`, () => { | ||
| expect(countChar("Code Your Future!", "Y")).toEqual(1); | ||
| }); | ||
|
|
||
|
Comment on lines
+32
to
+35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could include a lower case |
||
| test(`should return the count of character for non-alphabests`, () => { | ||
| expect(countChar("86421", "1")).toEqual(1); | ||
| }); | ||
|
|
||
| test(`should return 0 for empty strings`, () => { | ||
| expect(countChar("code your future", "")).toEqual(0) | ||
| }); | ||
|
|
||
| test(`should return the count for unusual characters`, () => { | ||
| expect(countChar("code& $future £your", "$")).toEqual(1) | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there is a more common name that describes characters that are neither alphabets nor digits, than "unusual characters". |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,19 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const lastDigit = num % 10; | ||
| const lastTwoDigits = num % 100; | ||
|
|
||
| if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { | ||
| return `${num}th`; | ||
| } else if (lastDigit === 1) { | ||
| return `${num}st`; | ||
| } else if (lastDigit === 2) { | ||
| return `${num}nd`; | ||
| } else if (lastDigit === 3) { | ||
| return `${num}rd`; | ||
| } else { | ||
| return `${num}th`; | ||
|
|
||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing more samples.
Could consider testing these cases:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, sir, for the review. I fixed all the suggested changes.