Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}
return count;
}

module.exports = countChar;
17 changes: 17 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,20 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("it should return 0 because the character doesn't occurrences", () => {
const str = "The character have no match";
const char = "z";
const count = countChar(str, char);
expect(count).toEqual(0);
});
// Scenario: 1 Occurrences
// Given the input string `str`,
// And a character `char` that have 1 character exist in `str`.
// When the function is called with these inputs,
// Then it should return 1, indicating that 1 occurrences of `char` were found.
test("it should return 1 because the character occurrences 1 time", () => {
const str = "code your future";
const char = "f";
const count = countChar(str, char);
expect(count).toEqual(1);
});
20 changes: 18 additions & 2 deletions Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
function getOrdinalNumber(num) {
return "1st";
function getOrdinalNumber(number) {
const lastTwoDigits = number % 100;
if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) {
return number + "th";
}
const lastDigit = number % 10;
let suffix;
if (lastDigit === 1) {
suffix = "st";
} else if (lastDigit === 2) {
suffix = "nd";
} else if (lastDigit === 3) {
suffix = "rd";
} else {
suffix = "th";
}

return number + suffix;
}

module.exports = getOrdinalNumber;
24 changes: 24 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,27 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});
// Case 1: Numbers ending with 1 (but not 11)
// When the number ends with 1, except those ending with 11,
// Then the function should return a string by appending "st" to the number.
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(42)).toEqual("42nd");
expect(getOrdinalNumber(1752)).toEqual("1752nd");
});
// Case 1: Numbers ending with 1 (but not 11)
// When the number ends with 1, except those ending with 11,
// Then the function should return a string by appending "st" to the number.
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments do not match the test being carried out. Do you still need these comments?

The same comments appear at several places in this file.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the first one and i cope and pasted it to save time but I forgot to change the cases i was doing

expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(83)).toEqual("83rd");
expect(getOrdinalNumber(653)).toEqual("653rd");
});
// Case 1: Numbers ending with 1 (but not 11)
// When the number ends with 1, except those ending with 11,
// Then the function should return a string by appending "st" to the number.
test("should append 'th' for numbers not ending with 1, 2 and 3 ", () => {
expect(getOrdinalNumber(5)).toEqual("5th");
expect(getOrdinalNumber(38)).toEqual("38th");
expect(getOrdinalNumber(15678)).toEqual("15678th");
});
11 changes: 8 additions & 3 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
function repeatStr() {
return "hellohellohello";
function repeatStr(word, times) {
if (times > 0) {
return word.repeat(times);
} else if (times < 0) {
return "Error:negative number not allowed";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked this in my previous review.

When a function that is expected to return a string is designed to return a string on error,
how should the caller distinguish the return value of these two function calls?

  • repeatStr("Error:negative number not allowed", 1)
  • repeatStr("Hello World", -1)

They both return the same value.


The requirement is "to throw an error when count is negative". Can you update this implementation and the Jest test accordingly?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the function and implemented jest test case for negative numbers.

} else {
return "";
}
}

module.exports = repeatStr;
26 changes: 21 additions & 5 deletions Sprint-3/2-practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,39 @@ const repeatStr = require("./repeat-str");
// Then it should return a string that contains the original `str` repeated `count` times.

test("should repeat the string count times", () => {
const str = "hello";
const count = 3;
const repeatedStr = repeatStr(str, count);
let word = "hello";
let times = 3;
const repeatedStr = repeatStr(word, times);
expect(repeatedStr).toEqual("hellohellohello");
});

// Case: handle count of 1:
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.

test("should repeat the string count times", () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about should return the original string when count is 1 (so that the description won't duplicate)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not correctly described at first now it's fixed.

let word = "code your future";
let times = 1;
const repeatedStr = repeatStr(word, times);
expect(repeatedStr).toEqual("code your future");
});
// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.

test("should repeat the string is empty ", () => {
let word = "hello";
let times = 0;
const repeatedStr = repeatStr(word, times);
expect(repeatedStr).toBe("");
});
// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.
test("should repeat the string return negative number not allowed ", () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two test descriptions do not quite make sense.

Can you rephrase them, for example, in the format: should <expected_behavior> when <condition> ?

let word = "hello";
let times = -3;
const repeatedStr = repeatStr(word, times);
expect(repeatedStr).toBe("Error:negative number not allowed");
});
Loading