Skip to content

Manchester | 26-ITP-JAN | Abdu Mussa | Sprint 3 | dead code #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abduhasen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-JAN | Abdu Mussa | Sprint 3 | dead code #1234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1ffce9
removing unreachable and redundant code
Abduhasen Mar 9, 2026
7d24e37
fixing dead code based on mentor comment
Abduhasen Mar 16, 2026
3644abf
removing dead code
Abduhasen Mar 16, 2026
f3f16c9
fixing dead code
Abduhasen Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
let testName = "Chris";
Copy link
Copy Markdown

@SlideGauge SlideGauge Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change the name?

const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
Copy link
Copy Markdown

@SlideGauge SlideGauge Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch this line is not needed either

return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);
Copy link
Copy Markdown

@SlideGauge SlideGauge Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greetingMessage const was not a dead code, it was used to pass it into console log. Whilst the new result more compact indeed, a line with several function calls in it is harder to read, and the task request was to remove dead code, not refactor working code.


console.log(greetingMessage); // 'hello, Aman!'
console.log(sayHello(greeting, testName));
6 changes: 0 additions & 6 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,7 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};

Expand Down
Loading