Skip to content

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | dead code #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marthak1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | dead code #1253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6599391
removed unused code from exercise
marthak1 Mar 12, 2026
2c3e8e1
Update petsStartingWithH filter for case insensitivity
marthak1 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";

return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";
Expand Down
4 changes: 0 additions & 4 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");
Copy link
Copy Markdown

@ykamal ykamal Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work if the character were uppercase?

Copy link
Copy Markdown
Author

@marthak1 marthak1 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Given this current code the answer is no, because the filter is only looking for lowercase character "h". I have now updated the filter for case sensitivity

Copy link
Copy Markdown

@ykamal ykamal Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 👍


function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand Down
Loading