Skip to content
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}
return count;
}

module.exports = countChar;
6 changes: 6 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("should return 0 when character is not found", () => {
const str = "codeyourfuture";
const char = "b";
const count = countChar(str, char);
expect(count).toEqual(0);
});
15 changes: 14 additions & 1 deletion Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
function getOrdinalNumber(num) {
return "1st";
let remainder1 = num % 10;
let remainder2 = num % 100;
if (remainder1 === 1 && remainder2 !== 11) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice is to give variables descriptive (self-explanatory) names. Can you rename these two variables to make the code more readable.

// we also can use if (num[-1]===1 && num.slice(-2)!==11)
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This expression (in the comment) is comparing a string to a number.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the comparison

return num + "st";
} else if (remainder1 === 2 && remainder2 !== 12) {
// we also can use if (num[-1]===2 && num.slice(-2)!==12)
return num + "nd";
} else if (remainder1 === 3 && remainder2 !== 13) {
// we also can use if (num[-1]===3 && num.slice(-2)!==13)
return num + "rd";
} else {
return num + "th";
}
}

module.exports = getOrdinalNumber;
43 changes: 43 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,46 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

// Case 2: Numbers ending with 2 (but not 12)
// When the number ends with 2, except those ending with 12,
// Then the function should return a string by appending "nd" to the number.
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(202)).toEqual("202nd");
expect(getOrdinalNumber(1032)).toEqual("1032nd");
});

// Case 3: Numbers ending with 3 (but not 13)
// When the number ends with 3, except those ending with 13,
// Then the function should return a string by appending "rd" to the number.
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(2333)).toEqual("2333rd");
expect(getOrdinalNumber(13453)).toEqual("13453rd");
});

// Case 4: numbers ending with 11, 12, or 13
// When the number ends with 11, 12, or 13,
// Then the function should return a string by appending "th" to the number.

test("should append 'th' for numbers ending with 11, 12, or 13", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(13)).toEqual("13th");
});

// Case 5: numbers that ends with 0, 4, 5, 6, 7, 8, or 9
// When the number does not end with 1, 2, or 3
// Then the function should return a string by appending "th" to the number.

test("should append 'th' for all other numbers", () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test description is what Jest output in the test report. It's better to replace "all other numbers" by the detailed condition described on line 50.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced

expect(getOrdinalNumber(4)).toEqual("4th");
expect(getOrdinalNumber(10)).toEqual("10th");
expect(getOrdinalNumber(11)).toEqual("115th");
expect(getOrdinalNumber(12)).toEqual("126th");
expect(getOrdinalNumber(13)).toEqual("137th");
expect(getOrdinalNumber(100)).toEqual("100th");
expect(getOrdinalNumber(1012)).toEqual("1012th");
expect(getOrdinalNumber(1038)).toEqual("1038th");
});
16 changes: 14 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function repeatStr() {
return "hellohellohello";
function repeatStr(str, count) {
if (count >= 0) {
return str.repeat(count);
} else {
throw new Error("Count cannot be a negative number");
}
}
// I can make the 3 valid cases in 1 case with the repeat method as folows:
// function repeatStr(str, count) {
// if (count >= 0) {
// return str.repeat(count);
// } else {
// throw new Error("Count cannot be a negative number");
// }
// }

module.exports = repeatStr;
22 changes: 22 additions & 0 deletions Sprint-3/2-practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,34 @@ test("should repeat the string count times", () => {
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.

test("should return the original string when count is 1", () => {
const str = "djebsoft";
const count = 1;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("djebsoft");
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.

test("should return an empty string when count is 0", () => {
const str = "djebsoft";
const count = 0;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("");
});

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.

test("should throw an error when count is negative", () => {
const str = "CYF";
const count = -2;
expect(() => repeatStr(str, count)).toThrow(
"Count cannot be a negative integer"
);
});
Loading