Skip to content

Glasgow | 25-ITP-Sep | Alaa Tagi| Sprint 3 | coursework/sprint 3 stretch #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alaa-Tagi wants to merge 14 commits into from
Closed

Glasgow | 25-ITP-Sep | Alaa Tagi| Sprint 3 | coursework/sprint 3 stretch #765

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
24f294c
write js card-validator code with explanation of some lines and some …
Alaa-Tagi Oct 13, 2025
6b8d975
answer the questions in the code
Alaa-Tagi Oct 13, 2025
8499ca3
Editing passwordValidator code
Alaa-Tagi Oct 13, 2025
14ab0f6
rewrite test with jest for password-validator
Alaa-Tagi Oct 13, 2025
e2191a4
fix the code
Alaa-Tagi Oct 13, 2025
7f09ec5
fix the code
Alaa-Tagi Oct 13, 2025
46024de
fix the code
Alaa-Tagi Oct 13, 2025
444fbb9
fix the code
Alaa-Tagi Oct 13, 2025
df9863b
fix the code
Alaa-Tagi Oct 13, 2025
9354edf
fixing code to meet all requirements
Alaa-Tagi Oct 27, 2025
d50290e
editing the code
Alaa-Tagi Oct 27, 2025
9abe2c9
Change line in the code to meet at least one symbol requirement
Alaa-Tagi Oct 30, 2025
e615f8a
change line in the code to meet rqirements
Alaa-Tagi Oct 30, 2025
08603d4
change line in the code to meet rqirements
Alaa-Tagi Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions Sprint-3/3-stretch/password-validator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test("password has at least 5 characters", () => {
// passsword has at least one uppercase letter
test("password has at least one uppercase letter", () => {

const password = "1234a";
const password = "abcd!1";
const result = isValidPassword(password);
expect(result).toEqual(false);
}
Expand All @@ -37,7 +37,7 @@ test("password has at least one uppercase letter", () => {
// password has at least one lowercase letter
test("password has at least one lowercase letter", () => {

const password = "1234A";
const password = "ABCD!1";
const result = isValidPassword(password);
expect(result).toEqual(false);
}
Expand All @@ -46,7 +46,7 @@ test("password has at least one lowercase letter", () => {
// password has at least one number
test("password has at least one number", () => {

const password = "abcdA";
const password = "Abcd!@";
const result = isValidPassword(password);
expect(result).toEqual(false);
}
Expand All @@ -55,7 +55,7 @@ test("password has at least one number", () => {
// password has at least one symbol:
test("password has at least one symbol: (!, #, $, %, ., *, &)", () => {

const password = "abcdA1";
const password = "abcd12";
const result = isValidPassword(password);
expect(result).toEqual(false);
}
Comment on lines 56 to 61
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two possible reasons the test could pass;
the new password does not contain any uppercase letter (in addition to not containing any symbol).

Comment on lines 56 to 61
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about this test is still not quite right. Can you fix the issue?

Expand All @@ -64,9 +64,16 @@ test("password has at least one symbol: (!, #, $, %, ., *, &)", () => {
// password must not be any previous password in the passwords array.
test("password must not be any previous password in the passwords array.", () => {

const password = "abcde1!";
const password = "abcd!1";
const result = isValidPassword(password);
expect(result).toEqual(false);
}
);

// password is valid when all requirements are met
test ("password is valid when it meets all requirements",() =>{

const password = "Abcd!2";
const result = isValidPassword(password);
expect(result).toEqual(true);
}
);