Skip to content

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 3 | Coursework/sprint-3-implement-and-rewrite#895

Closed
jakr-s wants to merge 9 commits into
CodeYourFuture:mainfrom
jakr-s:coursework/sprint-3-implement-and-rewrite
Closed

Sheffield | 25-ITP-Sep | Jak Rhodes-Smith | Sprint 3 | Coursework/sprint-3-implement-and-rewrite#895
jakr-s wants to merge 9 commits into
CodeYourFuture:mainfrom
jakr-s:coursework/sprint-3-implement-and-rewrite

Conversation

@jakr-s

@jakr-s jakr-s commented Dec 1, 2025

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all mandatory tasks

@jakr-s jakr-s added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 1, 2025
cjyuan
cjyuan reviewed Dec 1, 2025
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 1, 2025
@jakr-s jakr-s added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 3, 2025
@cjyuan

cjyuan commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Changes look good!

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 3, 2025
@jakr-s jakr-s mentioned this pull request Dec 4, 2025
Closed
@jakr-s jakr-s closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakr-s @cjyuan