-
-
Notifications
You must be signed in to change notification settings - Fork 386
London | ITP-Jan-26 | Abdul Moiz | Sprint 3 | Practice TDD #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| let stringNum = num.toString(); | ||
| let lastDigit = stringNum[stringNum.length - 1]; | ||
| if (lastDigit === "1" && num % 100 !== 11) { | ||
| return stringNum + "st"; | ||
| } else if (lastDigit === "2" && num % 100 !== 12) { | ||
| return stringNum + "nd"; | ||
| } else if (lastDigit === "3" && num % 100 !== 13) { | ||
| return stringNum + "rd"; | ||
| } else { | ||
| return stringNum + "th"; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,5 +16,29 @@ const getOrdinalNumber = require("./get-ordinal-number"); | |
| test("should append 'st' for numbers ending with 1, except those ending with 11", () => { | ||
| expect(getOrdinalNumber(1)).toEqual("1st"); | ||
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(31)).toEqual("131st"); | ||
| expect(getOrdinalNumber(31)).toEqual("31st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| //expect(getOrdinalNumber(31)).toEqual("131st"); Assuming this is a typo and should be 31st | ||
| }); | ||
|
|
||
| // Case 2: Numbers ending with 2 | ||
| test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(132)).toEqual("132nd"); | ||
| }); | ||
|
|
||
| // Case 3: Numbers ending with 3 | ||
| test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(143)).toEqual("143rd"); | ||
| }); | ||
|
|
||
| // Case 4: All other numbers | ||
| test("should append 'th' for all other numbers", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
|
Comment on lines
+41
to
+43
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could consider testing more samples in this category to make the test more comprehensive. |
||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count === 0) { | ||
| return ""; | ||
| } else if (count > 0) { | ||
| return str.repeat(count); | ||
| } else { | ||
| throw new Error("Count must be a non-negative integer"); | ||
| } | ||
| return ""; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code on line 9 is unreachable (we call them "dead code"). Could consider not using |
||
| } | ||
|
|
||
| module.exports = repeatStr; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved function by storing last 2 digit.