London | ITP-Jan-26 | Mohsen Zamani | Sprint 3 | practice tdd#923
Closed
mohsenzamanist wants to merge 5 commits into
Closed
London | ITP-Jan-26 | Mohsen Zamani | Sprint 3 | practice tdd#923mohsenzamanist wants to merge 5 commits into
mohsenzamanist wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
mohsenzamanist
added
the
Needs Review
cjyuan
reviewed
Feb 12, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
All functions are correctly implemented. Good job.
| if (["11", "12", "13"].includes(last2Digits)) return `${num}th`; | ||
|
|
||
| const lastDigit = String(num).slice(-1); | ||
| const restOfNum = String(num).slice(0, -1); |
Contributor
There was a problem hiding this comment.
This variable is unused. Can you remove it?
Note: In VSCode and in many IDEs, unused variables often appear in a different color in the editor.
cjyuan
added
Reviewed
mohsenzamanist
added
Needs Review
Contributor
|
LGTM. |
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed coursework/sprint-3-practice-tdd
Questions