-
-
Notifications
You must be signed in to change notification settings - Fork 386
London | ITP-Jan-26 | Mohsen Zamani | Sprint 3 | practice tdd #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mohsenzamanist
wants to merge
5
commits into
CodeYourFuture:main
from
mohsenzamanist:coursework/sprint-3-practice-tdd
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e16389e
Complete sprint-3/implementandrewritetests
mohsenzamanist 4e176f1
Complete coursework/sprint-3-practice-tdd
mohsenzamanist 75a06d4
Revert accidental changes to 1-implement-and-rewrite-tests
mohsenzamanist 4bbaa6b
Apply changes asked by the reviewer
mohsenzamanist 5130370
Merge branch 'main' into coursework/sprint-3-practice-tdd
mohsenzamanist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| return [...stringOfCharacters].reduce( | ||
| (acc, curr) => acc + (curr === findCharacter ? 1 : 0), | ||
| 0 | ||
| ); | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,24 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const last2Digits = String(num).slice(-2); | ||
| if (["11", "12", "13"].includes(last2Digits)) return `${num}th`; | ||
|
|
||
| const lastDigit = String(num).slice(-1); | ||
| const restOfNum = String(num).slice(0, -1); | ||
| let ordinalResult = ""; | ||
| switch (lastDigit) { | ||
| case "1": | ||
| ordinalResult = `${num}st`; | ||
| break; | ||
| case "2": | ||
| ordinalResult = `${num}nd`; | ||
| break; | ||
| case "3": | ||
| ordinalResult = `${num}rd`; | ||
| break; | ||
| default: | ||
| ordinalResult = `${num}th`; | ||
| } | ||
| return ordinalResult; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count < 0) throw new Error("Can not repeat negative times."); | ||
| return str.repeat(count); | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable is unused. Can you remove it?
Note: In VSCode and in many IDEs, unused variables often appear in a different color in the editor.