Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 1 | coursework/sprint-1

[Dan2Clouted]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I created a new branch "coursework/sprint-1" and i have completed all the work in the sprint-1 folder.

[Dan2Clouted]

Hi CJ, Thanks for reviewing my work, hopefully everything is done now. Below are the list of changes i have made.

1. Counted the function calls correctly (5 total: replaceAll x2, Number x2, console.log x1) and listed the lines.

2. Rephrased the error explanation to be accurate (the original issue was a malformedreplaceAllcall / arguments not written correctly, not “missing quotes”) and stated the correct fix replaceAll(",", "").

3. Clarified what Number(carPrice.replaceAll(",", "")) does: removes commas from the price string then converts the cleaned string into a number for calculation.

[cjyuan]

Changes look good and explanation is spot on. Well done.

Note: There was no "Needs Review" tag. I just assumed this PR was ready to be re-reviewed.

[Dan2Clouted]

Yes it was, my apologies i forgot to add the review tlabel.

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.