West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 2 | coursework/sprint-2 by alizada-dev · Pull Request #946 · CodeYourFuture/Module-Structuring-and-Testing-Data

alizada-dev · 2026-02-09T22:19:15Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed the Sprint-2 coursework exercises of the Structuring and Testing Data module.

magarpratik · 2026-02-15T00:10:20Z

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+    let bmi = weight / (height * height);


I noticed you've used let here and in most other places. Could we use another keyword which might be a better fit?

I used const instead of let

Nice! 👌

Could you also review the other places where let is being used?

For reference, here is the CYF Code Style Guide.

Yes, I reviewed the other exercises and changed let to const here as well: const value = Number(penceString.slice(0, -1)) / 100; which was required.

Nice! 👍 I can still see a few places where we can use const. Could you find them?

Yup! 👍

Could you review this file too?

I believe const is not suitable here:
let hours = Number(time.slice(0, 2));
let minutes = Number(time.slice(3, 5));
let ampm = hours >= 12 ? 'pm' : 'am';

because the variable value changes in the next lines of code. I changed these to const but gave error.

I believe one of them can be const because it is not reassigned. Could you work out which one?

Ahh, you got me there!! Thanks for pointing it out. Changed let to const in the ampm variable.

Nice one! I've changed the label to complete now.

illicitonion · 2026-05-04T17:26:38Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

alizada-dev added 5 commits February 9, 2026 14:39

Fixed the errors in the 1-key-errors folder

c3bbdff

completed the mandatory debugs

1a63f23

Implement completed

6549aaa

interpret is done

d3bb259

Fixed the format-time function

e5372e2

alizada-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026

magarpratik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026

magarpratik reviewed Feb 15, 2026

View reviewed changes

Comment thread Sprint-2/3-mandatory-implement/2-cases.js Outdated

magarpratik reviewed Feb 15, 2026

View reviewed changes

Comment thread Sprint-2/3-mandatory-implement/3-to-pounds.js

magarpratik reviewed Feb 15, 2026

View reviewed changes

Comment thread Sprint-2/5-stretch-extend/format-time.js

magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 15, 2026

alizada-dev added 3 commits February 15, 2026 14:53

gave const name to bmi variable

c064497

Changed toUpperCase to toUpperSnakeCase

d377ac2

Fixed an issue in format-time.js

c8da88b

alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 15, 2026

magarpratik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026

magarpratik reviewed Feb 15, 2026

View reviewed changes

Comment thread Sprint-2/3-mandatory-implement/2-cases.js Outdated

magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 15, 2026

alizada-dev added 2 commits February 15, 2026 19:19

fixed the error

0800bae

changed let to const

974fb62

alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 15, 2026

magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026

Changed let to const in 3-to-pounds.js file

a9ad155

alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 15, 2026

magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026

changed let to const in format-time.js file

155d15f

alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 16, 2026

magarpratik added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026

alizada-dev mentioned this pull request Mar 9, 2026

ITP-Jan-26 | Structuring and Testing Data | Fida H Ali Zada alizada-dev/My-Coursework-Planner#59

Open

illicitonion closed this May 4, 2026

Uh oh!

Uh oh!

Conversation

alizada-dev commented Feb 9, 2026

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants