Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Module Structuring and Testing Data by mahmoudshaabo1984 · Pull Request #976 · CodeYourFuture/Module-Structuring-and-Testing-Data

mahmoudshaabo1984 · 2026-02-17T01:01:20Z

I have completed the coursework for Sprint 1.

Work done:

Fixed all bugs in the 2-mandatory-errors directory.
Provided detailed interpretations and answered all questions in the 3-mandatory-interpret directory.
Ensured all variable naming and scoping issues were resolved.

Learners, PR Template

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

cjyuan

Code is quite well written. I mainly have some questions and suggestions.

cjyuan · 2026-02-18T23:07:52Z


 // Line 1 is a variable declaration, creating the count variable with an initial value of 0
 // Describe what line 3 is doing, in particular focus on what = is doing
+// The code adds 1 to the count variable.


Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.

Can you find out what one-word programming term describes the operation on line 3?

cjyuan · 2026-02-18T23:08:51Z

 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+console.log(num);
+// num represents a random integer between 1 and 100.


Phrases like "a number between X and Y" are not precise enough in a program specification, because they do not clearly state whether the endpoints X and Y are included.

We can also use the concise and precise interval notation to describe a range of values.

[, ] => inclusion

(, ) => exclusion

For example, [1, 10) means, all numbers between 1 and 10, including 1 but excluding 10.

cjyuan · 2026-02-18T23:09:30Z

-const cardNumber = 4533787178994213;
+const cardNumber = "4533787178994213";
 const last4Digits = cardNumber.slice(-4);


Suppose you were not allowed to modify the statement const cardNumber = 4533787178994213;
(that is, keep the variable's value unchanged).
How would you modify the code (through type conversion) so that you can still use .slice(-4) to extract the last 4 digits from the given number.

cjyuan · 2026-02-18T23:12:30Z

 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-
+// replaceAll might not work in older Node versions


Can you describe why the original code on line 5 does not work? Here is the code:
priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," ""));

Note: There is an easier way to fix the original code than replacing replaceAll() by replace().

cjyuan · 2026-02-18T23:13:33Z

+// 5. const pence = ...
+// It extracts the last two characters to represent the pence part and ensures it has two digits.


Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?

…m, interval notation, type conversion, fix syntax error explanation, and clarify padEnd redundancy

mahmoudshaabo1984 · 2026-02-19T17:12:11Z

Hi @cjyuan,

Thank you for reviewing my code and for your detailed feedback. I've updated all five files based on your suggestions:

1-count.js: Updated the comment to use the correct programming term — this is an increment operation.
4-random.js: Replaced "between 1 and 100" with proper interval notation: [1, 100]. I also added a step-by-step breakdown showing how the expression evaluates to this range.
3.js (mandatory-errors): Reverted cardNumber back to a number (without quotes) and used String(cardNumber).slice(-4) for type conversion instead of modifying the original value.
1-percentage-change.js: Corrected my explanation — the real error was a missing comma between the two arguments in replaceAll("," ""). The fix is simply adding the comma: replaceAll(",", "").
3-to-pounds.js: After testing with different inputs like "5p", "50p", and "399p", I concluded that .padEnd(2, "0") is actually not needed in this script because .padStart(3, "0") already guarantees at least 3 characters, so .substring() will always extract exactly 2 characters for the pence part.

Please let me know if there is anything else I should improve. I appreciate the feedback — it helped me understand these concepts more deeply.

Best regards,
Mahmoud

cjyuan · 2026-02-19T17:15:59Z

Thanks for answering all my questions, and they are all spot on! Excellent job!

cjyuan · 2026-02-19T17:57:36Z

Sorry, I beat you on the label. :P

illicitonion · 2026-05-04T17:25:29Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Complete all Sprint 1 exercises and fix errors

c7273b2

mahmoudshaabo1984 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026

cjyuan reviewed Feb 18, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 18, 2026

Update Sprint-1 answers based on reviewer feedback: use increment ter…

e62d2f2

…m, interval notation, type conversion, fix syntax error explanation, and clarify padEnd redundancy

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 19, 2026

mahmoudshaabo1984 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

mahmoudshaabo1984 mentioned this pull request Mar 13, 2026

Sheffield | Structuring and testing data | Mahmoud Shaabo mahmoudshaabo1984/My-Coursework-Planner#32

Open

8 tasks

illicitonion closed this May 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Module Structuring and Testing Data#976

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Module Structuring and Testing Data#976
mahmoudshaabo1984 wants to merge 2 commits into
CodeYourFuture:mainfrom
mahmoudshaabo1984:coursework/sprint-1

mahmoudshaabo1984 commented Feb 17, 2026

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Feb 18, 2026

Uh oh!

cjyuan Feb 18, 2026

Uh oh!

cjyuan Feb 18, 2026

Uh oh!

cjyuan Feb 18, 2026

Uh oh!

cjyuan Feb 18, 2026

Uh oh!

mahmoudshaabo1984 commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?

		// replaceAll might not work in older Node versions

		// 5. const pence = ...
		// It extracts the last two characters to represent the pence part and ensures it has two digits.

Uh oh!

Uh oh!

Conversation

mahmoudshaabo1984 commented Feb 17, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

mahmoudshaabo1984 commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants