refactor: wc implementation for easier readability

Author: XiaoQuark

implement-shell-tools/wc/wc.mjs

@@ -27,116 +27,92 @@ if (positionals.length === 0) {
 	process.exit(1);
 }
 
-const results = [];
+const fileCounts = [];
 
-// read file and calculate counts
 for (const path of positionals) {
-	const content = fs.readFileSync(path, "utf-8");
+	fileCounts.push(countFile(path));
+}
 
-	const lineCount = [...content].filter((char) => char === "\n").length;
+const totalCounts = {
+	lineCount: 0,
+	wordCount: 0,
+	byteCount: 0,
+};
 
-	const trimmedContent = content.trim();
+for (const file of fileCounts) {
+	totalCounts.lineCount += file.lineCount;
+	totalCounts.wordCount += file.wordCount;
+	totalCounts.byteCount += file.byteCount;
+}
 
-	const wordCount =
-		trimmedContent === "" ? 0 : trimmedContent.split(/\s+/).length;
+// output formatting
+const largestByteCount =
+	fileCounts.length > 1 ? totalCounts.byteCount : fileCounts[0].byteCount;
 
-	const byteCount = Buffer.byteLength(content);
+const width = String(largestByteCount).length;
 
-	results.push({
-		path,
-		lineCount,
-		wordCount,
-		byteCount,
-	});
+for (const file of fileCounts) {
+	const formattedCounts = formatCounts(file, width);
+
+	process.stdout.write(`${formattedCounts} ${file.path}\n`);
 }
 
-let totalLines = 0;
-let totalWords = 0;
-let totalBytes = 0;
+if (fileCounts.length > 1) {
+	const formattedTotals = formatCounts(totalCounts, width);
 
-// calculate total counts
-for (const result of results) {
-	totalLines += result.lineCount;
-	totalWords += result.wordCount;
-	totalBytes += result.byteCount;
+	process.stdout.write(`${formattedTotals} total\n`);
 }
 
-const allCounts = [];
+function countFile(path) {
+	const content = fs.readFileSync(path, "utf-8");
 
-for (const result of results) {
-	const counts = getSelectedCounts(
-		result.lineCount,
-		result.wordCount,
-		result.byteCount,
-	);
+	const lineCount = [...content].filter((char) => char === "\n").length;
 
-	allCounts.push(...counts);
-}
+	const trimmedContent = content.trim();
 
-if (results.length > 1) {
-	const totalCounts = getSelectedCounts(totalLines, totalWords, totalBytes);
+	const wordCount =
+		trimmedContent === "" ? 0 : trimmedContent.split(/\s+/).length;
 
-	allCounts.push(...totalCounts);
+	const byteCount = Buffer.byteLength(content);
+
+	return {
+		lineCount,
+		wordCount,
+		byteCount,
+		path,
+	};
 }
 
-// flags handling function
 function getSelectedCounts(lineCount, wordCount, byteCount) {
-	const counts = [];
+	const selectedCounts = [];
 
 	if (values.lines) {
-		counts.push(lineCount);
+		selectedCounts.push(lineCount);
 	}
 
 	if (values.words) {
-		counts.push(wordCount);
+		selectedCounts.push(wordCount);
 	}
 
 	if (values.bytes) {
-		counts.push(byteCount);
+		selectedCounts.push(byteCount);
 	}
 
-	if (counts.length === 0) {
-		counts.push(lineCount, wordCount, byteCount);
+	if (selectedCounts.length === 0) {
+		selectedCounts.push(lineCount, wordCount, byteCount);
 	}
 
-	return counts;
+	return selectedCounts;
 }
 
-// output formatting
-let largestByteCount = 0;
-
-for (const result of results) {
-	if (result.byteCount > largestByteCount) {
-		largestByteCount = result.byteCount;
-	}
-}
-
-if (results.length > 1 && totalBytes > largestByteCount) {
-	largestByteCount = totalBytes;
-}
-
-const width = String(largestByteCount).length;
-
-for (const result of results) {
-	const counts = getSelectedCounts(
-		result.lineCount,
-		result.wordCount,
-		result.byteCount,
+function formatCounts(counts, width) {
+	const selectedCounts = getSelectedCounts(
+		counts.lineCount,
+		counts.wordCount,
+		counts.byteCount,
 	);
 
-	const formattedCounts = counts
+	return selectedCounts
 		.map((count) => String(count).padStart(width))
 		.join(" ");
-
-	process.stdout.write(`${formattedCounts} ${result.path}\n`);
-}
-
-if (results.length > 1) {
-	const totalCounts = getSelectedCounts(totalLines, totalWords, totalBytes);
-
-	const formattedTotals = totalCounts
-		.map((count) => String(count).padStart(width))
-		.join(" ");
-
-	process.stdout.write(`${formattedTotals} total\n`);
 }