Skip to content

NW | 2026-mar-sdc | TzeMing Ho | Sprint 1 | individual-shell-tools-exercises#361

Open
TzeMingHo wants to merge 8 commits intoCodeYourFuture:mainfrom
TzeMingHo:coursework/individual-shell-tools
Open

NW | 2026-mar-sdc | TzeMing Ho | Sprint 1 | individual-shell-tools-exercises#361
TzeMingHo wants to merge 8 commits intoCodeYourFuture:mainfrom
TzeMingHo:coursework/individual-shell-tools

Conversation

@TzeMingHo
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have attempted to answer the questions. It was fun, and I learnt many new things.

@TzeMingHo TzeMingHo added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 12, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Apr 5, 2026
Copy link
Copy Markdown

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of files which do not have the trailing newline. Could you adjust settings of your editor please?

# TODO: Write a command to output, for each `.txt` file in this directory, how many lines of dialogue the Doctor has.
# The output should show that dialogue.txt contains 6 lines, dialogue-2.txt contains 2, and dialogue-3.txt contains 0.

grep -c ^Doctor *.txt No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if we met a line starting like this:
Doctorslike:
?


# TODO: Write a command which lists all of the files in the directory named child-directory.

ls -R ./child-directory
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does -R do? Do we need it in this context?

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 5, 2026
@SlideGauge
Copy link
Copy Markdown

Good job, there a couple of notes from my side, could you fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants